ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 38487: Enable JPA statement caching (internal/external)
Date Wed, 23 Sep 2015 20:01:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38487/#review100273
-----------------------------------------------------------

Ship it!


I'm also torn about the defaults and whether to have them enabled. I think that cached statements
can lead to negative performance gains in some scenarios but in most scenarios will have a
positive impact. With that said, we really don't have any basis for defaults or correctly
tuned values without performing some tests with the values off and then on. So, I guess we'll
leave them off for now and can recommend on how they can be enabled if necessary. 

I really would like to see a performance benchmark done comparing the off and on values on
a small and large Ambari deployment.

- Jonathan Hurley


On Sept. 23, 2015, 10:52 a.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38487/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 10:52 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Robert Nettleton.
> 
> 
> Bugs: AMBARI-13036
>     https://issues.apache.org/jira/browse/AMBARI-13036
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Problem: 
> 
> Ambari does not cache database statements which leads to excessive parsing.
> 
> Solution:
> 
> Added internal and external statement caching feature to Ambari. Caching used by default
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
e3686ac 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
a40fae6 
>   ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
074fbb4 
> 
> Diff: https://reviews.apache.org/r/38487/diff/
> 
> 
> Testing
> -------
> 
> Unit testing done.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:31 h
> [INFO] Finished at: 2015-09-17T17:21:55+00:00
> [INFO] Final Memory: 48M/605M
> [INFO] ------------------------------------------------------------------------
> 
> Functional testing:
> Locally: done on Postgres & MySQL databases
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message