ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 38183: Installing falcon with blueprint, oozie extensions are missing, hence causing misconfigured installations that are using blueprint.
Date Tue, 22 Sep 2015 13:05:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38183/#review99979
-----------------------------------------------------------

Ship it!


Patch looks fine to me.  

Thanks for adding the requested unit test.

- Robert Nettleton


On Sept. 18, 2015, 9:10 p.m., Sandor Magyari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38183/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 9:10 p.m.)
> 
> 
> Review request for Ambari, John Speidel, Robert Levas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-13017
>     https://issues.apache.org/jira/browse/AMBARI-13017
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PROBLEM
> 
> Installing falcon with blueprint, oozie extensions are missing, hence causing misconfigured
installations that are using blueprint.
> 
> SOLUTION
> 
> This issue seems to be related not only for case of falcon but for every service which
has a configuration file for another service.
> In case of falcon there is an oozie-site.xml (this contains oozie extensions) in configuration
of falcon service, which is marked as exclued-config-type in service metainfo.xml. The same
is true for AMBARI_METRICS which includes the storm-site.xml. In case of a bluprint install
these are excluded from properties, which is fine because you can not add a config-type twice.
The solution would to add these properties from excluded-config-type at update phase of properties
in BluprintConfigurationProcessor.doUpdateForClusterCreate.
> We can apply this only specifically for FALCON but I dont see yet any drawbacks of applying
it for each service with excluded property.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
892cf32 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
a97ca74 
> 
> Diff: https://reviews.apache.org/r/38183/diff/
> 
> 
> Testing
> -------
> 
> Manually tested, creating new cluster with blueprint, unitests passed, created a new
testcase.
> 
> 
> Thanks,
> 
> Sandor Magyari
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message