ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Szabo" <osz...@hortonworks.com>
Subject Re: Review Request 38487: Enable JPA statement caching (internal/external)
Date Fri, 18 Sep 2015 16:47:34 GMT


> On Sept. 18, 2015, 4:29 p.m., Robert Nettleton wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java,
line 77
> > <https://reviews.apache.org/r/38487/diff/1/?file=1076695#file1076695line77>
> >
> >     Why does the caching need to be set to "false" for the test module?

If I use caching I need to use EventBusSynchronizer.synchronizeAmbariEventPublisher in every
class where there are DAO operations (becasue of async events, entitymanager fails when trying
to close connection, but that is an issue only at testing..also it doesn't fail every time.
actually I used this synchronization approach only in ClustersTest.java)


> On Sept. 18, 2015, 4:29 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java,
line 218
> > <https://reviews.apache.org/r/38487/diff/1/?file=1076693#file1076693line218>
> >
> >     Should "50" be referred to from a constant somewhere?  
> >     
> >     It looks like this value is already defined in 
> >     
> >     Configuration.DEFAULT_JDBC_POOL_MAX_STATEMENTS_PER_CONNECTION 
> >     
> >     in this patch. 
> >     
> >     Is this the same default value? If so, then I'd recommend using a constant.
 If not, then define a separate default constant for this value. 
> >     
> >     Thanks.

yeah, I have a contant there. Configuration.SERVER_JDBC_CACHE_SIZE_DEFAULT for this one. My
bad, I kept it here when I tried to using different values


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38487/#review99543
-----------------------------------------------------------


On Sept. 18, 2015, 1:24 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38487/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 1:24 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Robert Nettleton.
> 
> 
> Bugs: AMBARI-13036
>     https://issues.apache.org/jira/browse/AMBARI-13036
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Problem: 
> 
> Ambari does not cache database statements which leads to excessive parsing.
> 
> Solution:
> 
> Added internal and external statement caching feature to Ambari. Caching used by default
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
e3686ac 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
a40fae6 
>   ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
074fbb4 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
174d489 
>   ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
a1e2b48 
> 
> Diff: https://reviews.apache.org/r/38487/diff/
> 
> 
> Testing
> -------
> 
> Unit testing done.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:31 h
> [INFO] Finished at: 2015-09-17T17:21:55+00:00
> [INFO] Final Memory: 48M/605M
> [INFO] ------------------------------------------------------------------------
> 
> Functional testing:
> Locally: done on Postgres & MySQL databases
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message