ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 38492: RU - Skipping failed task caused remaining pending tasks to be ABORTED
Date Fri, 18 Sep 2015 14:50:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38492/#review99531
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java (line
304)
<https://reviews.apache.org/r/38492/#comment156456>

    How do we mark a stage to be skippable? Is it explicit based on type of operations (e.g.
Install Packages)? There is another JIRA where we need this capability. So I am wondering


- Sumit Mohanty


On Sept. 18, 2015, 2:41 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38492/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 2:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-13145
>     https://issues.apache.org/jira/browse/AMBARI-13145
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Aborting a failed task during an upgrade causes the entire upgrade request to become
ABORTED. The ActionScheduler has logic which will abort an entire request if the command's
success factor was not met. This logic also needs to take into account skippable stages which
will be marked as COMPLETED even with failed tasks.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
7d93638 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
31356bb 
> 
> Diff: https://reviews.apache.org/r/38492/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message