ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Re: Review Request 38405: Minor optimizations for AMS memory settings
Date Thu, 17 Sep 2015 17:14:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38405/#review99407
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Sept. 17, 2015, 4:19 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38405/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 4:19 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13105
>     https://issues.apache.org/jira/browse/AMBARI-13105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Desired changes:
> HBase Xmn size was not adjusted
> We could round off the integers to more reasonable size in MB, like 2048 vs 1925 (Not
urgent)
> Warning message suggested allocating more memory to Xmx but Xmn adjustments are not suggested.
Lets decide on maybe taking these out and rely on a ratio. (The original settings were recommendation
from HBase team, lets adjust these based on our testing)
> The "m" / "g" etc, for heap size parameter is inconsistent (meaning sometime present
sometimes not), not sure if this is UI or BE problem
> The suggestion that tmp dir should not be on root partition is fine but it should also
mention, do not put it on same partition as hbase.rootdir, lets take out the fact that tmp.dir
would be cleaned up.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 4d1ab23

>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 8b3bee2 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 4c29dd8 
> 
> Diff: https://reviews.apache.org/r/38405/diff/
> 
> 
> Testing
> -------
> 
> OK
> ----------------------------------------------------------------------
> Total run:778
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message