ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yusaku Sako" <yus...@hortonworks.com>
Subject Re: Review Request 38303: Attributes of configuration property should be stack API driven
Date Sat, 12 Sep 2015 01:02:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38303/#review98721
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Sept. 12, 2015, 1 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38303/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 1 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13069
>     https://issues.apache.org/jira/browse/AMBARI-13069
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> *Following attributes of configuration properties should be made stack API driven:*
> # Visibility of configuration property exposed from API as visible value attribute
> # display name of configuration property exposed from API as display_name 
> # Empty value validity of configuration property exposed from API as empty_value_valid
value attribute
> # Restriction of being configured only once on installation exposed from API as editable_only_at_install
value attribute
> # overridable in config host group exposed from aPI as overridable vlaue attribute
> # Name of the property should be hidden exposed from API as show_property_name value
attribute
> 
> *Achieving this task will be useful in following scenarios:*
> # custom services could be added with less changes in ambari-web code
> # Any issues related to configuration property attributes encountered on a deployed cluster
can be addressed by making stack changes rather than redeploying ambari-web code with a fix.
For example if a property tagged as not overridable if later desired to be made overridable
on a deployed cluster will now require changing a boolean flag in stack configuration property
rather than changing ambari-web code.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
0525488 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
8054c54 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
67da50e 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-log4j.xml
e8f6e56 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml
2a7e083 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
e84193c 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-log4j.xml
64cc9d3 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-security-site.xml
6f60736 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-log4j.xml
6d3703e 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
5c7a39b 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
75178d2 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml
451ebb5 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-conf.xml
8ff764b 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-env.xml
e150478 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
03db5df 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-log4j.xml
64cc9d3 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml
b224bef 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml
4cb2274 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-log4j.xml
08822eb 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml
dc7f661 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
2d0a182 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-exec-log4j.xml
fb852f7 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-log4j.xml
a978ef7 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
2783b78 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-log4j.xml
0ded4d4 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml
33f7f21 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-env.xml
94f4975 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/configuration/kafka-log4j.xml
901859e 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
60df2e0 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml
5cf0960 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/gateway-log4j.xml
370f786 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/knox-env.xml
bbd3d12 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ldap-log4j.xml
a0cf658 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
8bf1dd3 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/topology.xml
89527b3 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/users-ldif.xml
ace4858 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-log4j.xml
c5ee937 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
bc42bc6 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-log4j.xml
7f7158f 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml
329ac64 
>   ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml
f449421 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/configuration/pig-log4j.xml
4fe323c 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/configuration/pig-properties.xml
7916680 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml
0558d21 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml
3eb86fb 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml
cb7bd2b 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml
42db997 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml
e5bd75e 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/configuration/slider-log4j.xml
709867c 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/configuration/spark-defaults.xml
4491469 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/configuration/spark-javaopts-properties.xml
c2db325 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/configuration/spark-log4j-properties.xml
2ba64fb 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/configuration/spark-metrics-properties.xml
9af5f2e 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml
49d3f04 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-env.xml
b387102 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-env.xml
6eb1a1d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-log4j.xml
8c44b9e 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml
26a74df 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/configuration/zoo.cfg.xml
12e2a00 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/configuration/zookeeper-env.xml
608f504 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/configuration/zookeeper-log4j.xml
6fcf5bc 
>   ambari-server/src/main/resources/properties.json 2dc1af5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 47dffec

>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/GLUSTERFS/configuration/core-site.xml
7794ac8 
>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/GLUSTERFS/configuration/hadoop-env.xml
bce6b53 
>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/HBASE/configuration/hbase-site.xml
cf8ddd3 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
182acfe 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml
a429a13 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/PIG/configuration/pig-properties.xml
480be75 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-env.xml
9ad95ac 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-env.xml
0e21eb0 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-site.xml
3451585 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml
30af22c 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/core-site.xml
1e68146 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml
4cee438 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-log4j.xml
bc8d959 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-site.xml
c1ff588 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
32f7c54 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml
443648f 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
5811e4f 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml
1b121bc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/webhcat-site.xml
49563de 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml
e0c47db 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-site.xml
aaf027d 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/GLUSTERFS/configuration/core-site.xml
8b382dd 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/GLUSTERFS/configuration/hadoop-env.xml
e9078e2 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/HBASE/configuration/hbase-site.xml
7cfac16 
>   ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/OOZIE/configuration/oozie-site.xml
5208943 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/ACCUMULO/configuration/accumulo-log4j.xml
20c858e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/hbase-site.xml
34dff85 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml
070b637 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-security.xml
8958a9e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml
3b332ad 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hdfs-site.xml
b14d73a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml
57329e3 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml
d5f07a9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml
5407ccf 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-audit.xml
1433d0a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml
893652d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml
ba8710a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/PIG/configuration/pig-properties.xml
c18e25a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml
57d21dd 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml
dd6270c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml
d7dce19 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml
3687e88 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml
bbe0a3d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/TEZ/configuration/tez-site.xml
be534f1 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml
044f8ec 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-plugin-properties.xml
db456da 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-log4j.xml
28a4836 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-site.xml
f2774fc 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/configuration/cluster-env.xml 24294a4

>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMBARI_METRICS/configuration/ams-env.xml
ff779d1 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMBARI_METRICS/configuration/ams-site.xml
097de9d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FALCON/configuration/falcon-env.xml
6ececc6 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/configuration/flume-conf.xml
8ff764b 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/configuration/hbase-env.xml
642e746 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/configuration/hbase-site.xml
d551d4d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HDFS/configuration/hadoop-env.xml
b5451d8 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HDFS/configuration/hdfs-site.xml
b235da4 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/configuration/hive-env.xml
6fa7a08 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/configuration/hive-site.xml
18aaf5f 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/OOZIE/configuration/oozie-env.xml
138e3e2 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/OOZIE/configuration/oozie-site.xml
1693648 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration-mapred/mapred-env.xml
a8feead 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration/yarn-env.xml
726704d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/ZOOKEEPER/configuration/zoo.cfg.xml
6505500 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/ZOOKEEPER/configuration/zookeeper-env.xml
64dd971 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HBASE/configuration/hbase-env.xml
e46932a 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HBASE/configuration/hbase-site.xml
3de0397 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HDFS/configuration/hdfs-log4j.xml
bc8d959 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-site.xml
3446bc6 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/webhcat-site.xml
2de5225 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/STORM/configuration/storm-site.xml
480bef8 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HBASE/configuration/hbase-site.xml
2939836 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HDFS/configuration/hdfs-site.xml
5f2db0c 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/OOZIE/configuration/oozie-env.xml
1db1b6e 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/OOZIE/configuration/oozie-site.xml
4e5bb61 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/STORM/configuration/storm-site.xml
67cc62d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/TEZ/configuration/tez-site.xml
8f4ff63 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
14c66a2 
>   ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml
d26b83e 
>   ambari-web/app/assets/test/tests.js 64ddb30 
>   ambari-web/app/data/HDP2.2/site_properties.js 019a4eb 
>   ambari-web/app/data/HDP2.3/site_properties.js 5a25ecb 
>   ambari-web/app/data/HDP2/site_properties.js 0cda85c 
>   ambari-web/app/models/configs/objects/service_config_property.js 15c5451 
>   ambari-web/app/models/configs/stack_config_property.js a1925a4 
>   ambari-web/app/utils/config.js a578f34 
>   ambari-web/test/data/HDP2.2/site_properties_test.js PRE-CREATION 
>   ambari-web/test/data/HDP2.3/site_properties_test.js PRE-CREATION 
>   ambari-web/test/data/HDP2/site_properties_test.js ced9376 
>   ambari-web/test/utils/config_test.js 6aabc2d 
> 
> Diff: https://reviews.apache.org/r/38303/diff/
> 
> 
> Testing
> -------
> 
> Tested manually by installing a cluster with the patch
> Verified that all ambari-web unit test passes:
> 
>   9427 tests complete (11 seconds)
>   95 tests pending
> 
> Verified that edited ambari-server unit test passes: mvn clean -Dtest=AmbariMetaInfoTest
test
> 
> Ran 240 tests in 6.823s
> 
> OK
> ----------------------------------------------------------------------
> Total run:762
> Total errors:0
> Total failures:0
> OK
> StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
> Returning DefaultStackAdvisor implementation
> StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
> StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
> Returning XYZ101StackAdvisor implementation
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 02:22 min
> [INFO] Finished at: 2015-09-11T08:37:27-07:00
> [INFO] Final Memory: 52M/601M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message