ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Review Request 38243: Ambari should support custom stack names
Date Thu, 10 Sep 2015 01:28:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38243/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Sid Wagle.


Bugs: AMBARI-12597
    https://issues.apache.org/jira/browse/AMBARI-12597


Repository: ambari


Description
-------

Ambari should support custom stack names - when custom stack names are used the parsing logic
should parse only the version. This fix assumes that custom stacks are named XYZ-VERSION.NAME
where XYZ is the type and Version is integers separated by dots and then any string as name.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
0fb2f10 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 25c2260

  ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 89c10c6 
  ambari-server/src/main/java/org/apache/ambari/server/utils/VersionUtils.java 4d1fc48 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java
442bcb2 
  ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java 433d1c9


Diff: https://reviews.apache.org/r/38243/diff/


Testing
-------

Added unit tests, ran relevant unit tests.


Thanks,

Sumit Mohanty


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message