ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 38196: Optimize precision table Region split policy for AMS
Date Wed, 09 Sep 2015 20:09:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38196/#review98258
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/split_points.py
(line 46)
<https://reviews.apache.org/r/38196/#comment154597>

    This is still called several times in initialize_region_counts. You can still make it
readable while doing something like this outside of the function.
    
    b_bytes = 1
    k_bytes = 1 << 10  # 1024
    m_bytes = 1 << 20  # 1024^2
    g_bytes = 1 << 30  # 1024^3
    t_bytes = 1 << 40  # 1024^4
    p_bytes = 1 << 50  # 1024^5
    
     m = {
        modifier == 'b': b_bytes,
        modifier == 'k': k_bytes,
        modifier == 'm': m_bytes,
        modifier == 'g': g_bytes,
        modifier == 't': t_bytes,
        modifier == 'p': p_bytes
        } [1]


- Alejandro Fernandez


On Sept. 9, 2015, 7:56 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38196/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 7:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Mahadev Konar, Myroslav Papirkovskyy,
Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-13039
>     https://issues.apache.org/jira/browse/AMBARI-13039
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - In light of AMBARI-12983, performance would be seen if the precision table can fully
utilize the allocated memstore heap.
> - With the single table getting most of the high volume reads and all of the high volume
writes it is important to define a policy for splitting the Region in order to optimize performance
of the scans.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
1bd20a3 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
d70d77d 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
fa30e19 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/AMBARI_METRICS.txt
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/FLUME.txt
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/HBASE.txt
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/HDFS.txt
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/HOST.txt
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/KAFKA.txt
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/STORM.txt
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/service-metrics/YARN.txt
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/split_points.py
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38196/diff/
> 
> 
> Testing
> -------
> 
> Unit test pass.
> Verfied region splits occur as expected.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message