ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Re: Review Request 38221: AMS: IOException: maxStamp is smaller than minStamp
Date Wed, 09 Sep 2015 19:26:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38221/#review98248
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Sept. 9, 2015, 4 p.m., Ivan Kozlov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38221/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 4 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sid Wagle.
> 
> 
> Bugs: AMBARI-13049
>     https://issues.apache.org/jira/browse/AMBARI-13049
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMS responses with exception
> {
> exception: "RuntimeException"
> message: "java.io.IOException: maxStamp is smaller than minStamp"
> javaClassName: "java.lang.RuntimeException"
> }
> to the request
> http://ams-host:6188/ws/v1/timeline/metrics?metricNames=cpu_system&appId=HOST&hostname=host1&startTime=1441141200000&endTime=1441142880000
> ambari-metrics-collector.log contains
>  20:28:30,860  WARN [2081437567@qtp-24334184-377] GenericExceptionHandler:98 - INTERNAL_SERVER_ERROR
> java.lang.RuntimeException: java.io.IOException: maxStamp is smaller than minStamp
>         at org.apache.phoenix.util.ScanUtil.setTimeRange(ScanUtil.java:253)
>         at org.apache.phoenix.execute.BaseQueryPlan.iterator(BaseQueryPlan.java:188)
>         at org.apache.phoenix.execute.BaseQueryPlan.iterator(BaseQueryPlan.java:155)
>         at org.apache.phoenix.jdbc.PhoenixStatement$1.call(PhoenixStatement.java:220)
>         at org.apache.phoenix.jdbc.PhoenixStatement$1.call(PhoenixStatement.java:211)
>         at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
>         at org.apache.phoenix.jdbc.PhoenixStatement.executeQuery(PhoenixStatement.java:210)
>         at org.apache.phoenix.jdbc.PhoenixPreparedStatement.executeQuery(PhoenixPreparedStatement.java:183)
>         at org.apache.hadoop.yarn.server.applicationhistoryservice.metrics.timeline.PhoenixHBaseAccessor.getMetricRecords(PhoenixHBaseAccessor.java:420)
>         at org.apache.hadoop.yarn.server.applicationhistoryservice.metrics.timeline.HBaseTimelineMetricStore.getTimelineMetrics(HBaseTimelineMetricStore.java:154)
>         at org.apache.hadoop.yarn.server.applicationhistoryservice.webapp.TimelineWebServices.getTimelineMetrics(TimelineWebServices.java:372)
>         at sun.reflect.GeneratedMethodAccessor38.invoke(Unknown Source)
> 1. AMS should have a check in PhoenixHBaseAccessor.getMetricRecords() if maxStamp >=
minStamp before running a query
> 2. AMS shouldn't throw an IOException to the response, if the exception catched, the
response should contain an empty metrics array.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
1bd20a3 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38221/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ambari-metrics .................................... SUCCESS [1.196s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [3.084s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [5.471s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [4.225s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [5.577s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [3.335s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [6:26.732s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [5.833s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [6:24.376s]
> 
> 
> Thanks,
> 
> Ivan Kozlov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message