ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 38181: Automatically Skip Failed Tasks Of Slaves During Upgrade
Date Tue, 08 Sep 2015 20:35:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38181/#review98061
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java
(line 43)
<https://reviews.apache.org/r/38181/#comment154271>

    Should this default to true?


- Alejandro Fernandez


On Sept. 8, 2015, 4:41 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38181/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 4:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-13032
>     https://issues.apache.org/jira/browse/AMBARI-13032
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During an upgrade, if any slave component experiences a failure during its restart state
then there should be a way for the rest of the upgrade group to automatically continue despite
the failure. This will prevent the need of administrators to babysit the upgrade process,
especially in cases of larger clusters.
> 
> During the creation of the upgrade, an optional parameter should be supplied to the REST
endpoint to accomplish this.
> 
> {code:title=POST api/v1/clusters/c1/upgrades}
> {
>   "Upgrade": {
>     "repository_version": "2.3.0.0-2545",
>     "skip_failures": true
>   }
> }
> {code}
> 
> The various skippable parts of the upgrade can be broken out into distinct request parameters:
> - {{skip_failures}} (skips all component failures)
> - {{skip_service_check_failures}} (skips all service check failures)
> 
> If an upgrade begins without the skip option specified, it can later be added:
> 
> {code:title=PUT api/v1/clusters/c1/upgrades/1}
> {
>   "Upgrade": {
>     "skip_failures": true
>   }
> }
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
62f8be9 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java
9d44454 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommandFactory.java
84c2d2a 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommandFactoryImpl.java
0440f87 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java
39cbabc 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java fcd0324

>   ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java
ee5febe 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
a422b2d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
43bdbfe 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
a90cb31 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
6f407c9 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
a942c93 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
1051056 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
770cc04 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
9c91656 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandStatusSummaryDTO.java
54ade92 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
d99da6d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 86dbccd

>   ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java b7f95cf

>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java
02df181 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 3da0fe2

>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 265e42e 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0053837 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 30b669d 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 4f7569c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 97b5e11 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 81d0e6f 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 04befaf 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
8d21b80 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/StageTest.java fa1e770

>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
520be9f 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java
27f11f7 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
cfbc38e 
>   ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestStage.java 13453df

>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
4a4f8c9 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
4235ccd 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java
4700202 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java
0342bf2 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/ServerActionExecutorTest.java
193e3d5 
>   ambari-server/src/test/java/org/apache/ambari/server/stageplanner/TestStagePlanner.java
0d36048 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java
7a394ca 
> 
> Diff: https://reviews.apache.org/r/38181/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 3172, Failures: 0, Errors: 0, Skipped: 25
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:34 min
> [INFO] Finished at: 2015-09-08T10:28:04-04:00
> [INFO] Final Memory: 42M/1275M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message