ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oliver Szabo" <osz...@hortonworks.com>
Subject Re: Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is "Corrupted replica"
Date Fri, 04 Sep 2015 14:49:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38095/
-----------------------------------------------------------

(Updated Sept. 4, 2015, 2:49 p.m.)


Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Bugs: AMBARI-12931
    https://issues.apache.org/jira/browse/AMBARI-12931


Repository: ambari


Description
-------

Problem:

- Corrupted Block metric on the UI means corrupted replicas. 

Solution:

- In fact this metric comes from hadoop: 
 
  FSNamesystem.java:
  
  @Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"})
  public long getCorruptReplicaBlocks() {
    return blockManager.getCorruptReplicaBlocksCount();
  }
- Because of that "CorruptedBlock" references are correct on the ambari side. I suggest only
UI change, what clarifies the definition.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 7e93a6e 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json e47d431 
  ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json a97c9e5 
  ambari-web/app/messages.js 7912937 

Diff: https://reviews.apache.org/r/38095/diff/


Testing
-------

Manually tested on local VM.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:14 h
[INFO] Finished at: 2015-09-03T01:06:58+00:00
[INFO] Final Memory: 50M/619M
[INFO] ------------------------------------------------------------------------


Thanks,

Oliver Szabo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message