ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Review Request 38127: RU: Installing version stuck on host
Date Fri, 04 Sep 2015 13:51:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38127/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-13014
    https://issues.apache.org/jira/browse/AMBARI-13014


Repository: ambari


Description
-------

ambari-server-2.1.0-1462.x86_64
Attempting to register and install a repo version was stuck on one of the hosts.
The cluster version was stuck in INSTALLING, and so was one of the hosts; the other hosts
were fine
Log from host were it failed

```
2015-09-03 12:21:59,319 - Attempting to determine actual version with build number.
2015-09-03 12:21:59,319 - Old versions: ['2.3.2.0-2598', '2.3.2.0-2716']
2015-09-03 12:21:59,369 - New versions: ['2.3.2.0-2598', '2.3.2.0-2716']
2015-09-03 12:21:59,369 - Deltas: set([])
2015-09-03 12:21:59,370 - Cannot determine a new actual version installed by using the delta
method.
2015-09-03 12:21:59,370 - Found actual version 2.3.2.0-210 by parsing file /var/lib/ambari-agent/data/repo_version_history.csv
```

In fact, the bug (at least at branch-2.1.0) is that we can not overwrite old build version
of the same stack. For example, 

```
>>> import repo_version_history
>>> import logging
>>> Logger = logging.getLogger()
>>> global Logger
>>> repo_version_history.write_actual_version_to_history_file('2.3.2.0', '2.3.2.0-210')
False
>>> repo_version_history.write_actual_version_to_history_file('2.3.2.0', '2.3.2.0-2716')
False
```

produces
```
cat /tmp/repo_version_history.csv
2.3.2.0,2.3.2.0-210
```

Originally check for existing repo version was added to avoid appending the same repo version
multiple times to file. But later we decided to consider only "normalized" repo version (without
build number) and introduced this bug

So the bug STR is to:
- successfully install first repo version on host
- install second repo version (of the same stack) on host, and it should fail during installation.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/repo_version_history.py
f8ea7c9 
  ambari-server/src/test/python/custom_actions/TestRepoVersionHistory.py PRE-CREATION 

Diff: https://reviews.apache.org/r/38127/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [2.138s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.105s]
[INFO] Ambari Server ..................................... SUCCESS [51.800s]
[INFO] Ambari Agent ...................................... SUCCESS [7.897s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:03.538s
[INFO] Finished at: Fri Sep 04 16:43:50 EEST 2015
[INFO] Final Memory: 76M/1012M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message