ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 38095: Ambari UI shows "Corrupted Blocks" but it is "Corrupted replica"
Date Thu, 03 Sep 2015 19:49:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38095/#review97670
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json (line 250)
<https://reviews.apache.org/r/38095/#comment153687>

    widget_name_widget_layout_name acts as primary id for a widget. if widget_name is changed
then on upgrade scenario backend will create the new widget and keep the existing widget and
we will end up with 2 instances of the widget with different names.
    
    Lets not change the name for the widget and just change the description.


- Jaimin Jetly


On Sept. 3, 2015, 9:42 a.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38095/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2015, 9:42 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12931
>     https://issues.apache.org/jira/browse/AMBARI-12931
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Problem:
> 
> - Corrupted Block metric on the UI means corrupted replicas. 
> 
> Solution:
> 
> - In fact this metric comes from hadoop: 
>  
>   FSNamesystem.java:
>   
>   @Metric({"CorruptBlocks", "Number of blocks with corrupt replicas"})
>   public long getCorruptReplicaBlocks() {
>     return blockManager.getCorruptReplicaBlocksCount();
>   }
> - Because of that "CorruptedBlock" references are correct on the ambari side. I suggest
only UI change, what clarifies the definition.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 7e93a6e

>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json e47d431

>   ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json a97c9e5 
>   ambari-web/app/messages.js 7912937 
> 
> Diff: https://reviews.apache.org/r/38095/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on local VM.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:14 h
> [INFO] Finished at: 2015-09-03T01:06:58+00:00
> [INFO] Final Memory: 50M/619M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message