ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 37953: SQLA: add property validation check for BP oozie/hive, about SQLA should be available only for stack 2.3+
Date Tue, 01 Sep 2015 16:43:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37953/#review97301
-----------------------------------------------------------

Ship it!


The basic change looks ok to me, but unit tests should be added to verify this change. 

Could the author also please update the review with the associated JIRA, and a description
of the patch?  

Thanks.


ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
(line 103)
<https://reviews.apache.org/r/37953/#comment153137>

    Could the author of this patch please add new unit tests to verify this change to the
validator?  
    
    Thanks.


- Robert Nettleton


On Sept. 1, 2015, 3:40 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37953/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 3:40 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
70d1907 
> 
> Diff: https://reviews.apache.org/r/37953/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message