Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 15A981895E for ; Wed, 26 Aug 2015 20:49:22 +0000 (UTC) Received: (qmail 60325 invoked by uid 500); 26 Aug 2015 20:49:21 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 60276 invoked by uid 500); 26 Aug 2015 20:49:21 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 60146 invoked by uid 99); 26 Aug 2015 20:49:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2015 20:49:21 +0000 Date: Wed, 26 Aug 2015 20:49:21 +0000 (UTC) From: "Nate Cole (JIRA)" To: dev@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AMBARI-9501) Stack definition files include tab characters MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AMBARI-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nate Cole updated AMBARI-9501: ------------------------------ Fix Version/s: (was: 2.1.1) 2.1.2 > Stack definition files include tab characters > --------------------------------------------- > > Key: AMBARI-9501 > URL: https://issues.apache.org/jira/browse/AMBARI-9501 > Project: Ambari > Issue Type: Bug > Components: ambari-server > Affects Versions: 2.0.0 > Reporter: Robert Nettleton > Fix For: 2.1.2 > > > Some files in the stack defintions have recently been added with tab characters included, instead of using the "Tabs as spaces" convention that is specified in the Ambari Coding guidelines: > https://cwiki.apache.org/confluence/display/AMBARI/Coding+Guidelines+for+Ambari > The following files appear to use actual tab characters for spacing: > Under ambari-server: > src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml > src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml > src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml > src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml > src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml > Having tab characters in these config files can cause problems for patches that modify these files, since the IDEs we typically use do not use tab characters. This can cause the formatting of the actual diff between the branch and the local changes to not look as expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)