Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 60C8818F21 for ; Tue, 25 Aug 2015 11:52:31 +0000 (UTC) Received: (qmail 18457 invoked by uid 500); 25 Aug 2015 11:52:31 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 18427 invoked by uid 500); 25 Aug 2015 11:52:31 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 18414 invoked by uid 99); 25 Aug 2015 11:52:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Aug 2015 11:52:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3FDE426AA58; Tue, 25 Aug 2015 11:52:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6412956652597927856==" MIME-Version: 1.0 Subject: Review Request 37757: Installing Ambari-2.1.0 removes /etc/sudoers.d/ambari-agent file From: "Andrew Onischuk" To: "Vitalyi Brodetskyi" Cc: "Andrew Onischuk" , "Ambari" Date: Tue, 25 Aug 2015 11:52:30 -0000 Message-ID: <20150825115230.13584.53629@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Andrew Onischuk" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37757/ X-Sender: "Andrew Onischuk" Reply-To: "Andrew Onischuk" X-ReviewRequest-Repository: ambari --===============6412956652597927856== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37757/ ----------------------------------------------------------- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-12870 https://issues.apache.org/jira/browse/AMBARI-12870 Repository: ambari Description ------- As part of a prior fix, the file got removed from the rpm package. This has the side effect of user edited file getting removed during upgrade. Modify Ambari upgrade logic to not remove `/etc/sudoers.d/ambari-agent` and if that is not possible at least make a copy of the file and save a backup. Diffs ----- ambari-agent/src/main/package/rpm/preinstall.sh fc6719b Diff: https://reviews.apache.org/r/37757/diff/ Testing ------- mvn clean test Thanks, Andrew Onischuk --===============6412956652597927856==--