Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 59B6A187C0 for ; Fri, 21 Aug 2015 16:50:40 +0000 (UTC) Received: (qmail 67506 invoked by uid 500); 21 Aug 2015 16:50:35 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 67474 invoked by uid 500); 21 Aug 2015 16:50:35 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 67458 invoked by uid 99); 21 Aug 2015 16:50:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Aug 2015 16:50:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AEC701CCB1C; Fri, 21 Aug 2015 16:50:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1059177952874173573==" MIME-Version: 1.0 Subject: Re: Review Request 37678: Downgrades That Are Retried With Unhealthy Hosts Can Produce Multiple Stages In Progress From: "Robert Nettleton" To: "Alejandro Fernandez" , "Robert Levas" , "Robert Nettleton" Cc: "Ambari" , "Jonathan Hurley" Date: Fri, 21 Aug 2015 16:50:34 -0000 Message-ID: <20150821165034.1354.23339@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Robert Nettleton" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37678/ X-Sender: "Robert Nettleton" References: <20150821134537.1483.48027@reviews.apache.org> In-Reply-To: <20150821134537.1483.48027@reviews.apache.org> Reply-To: "Robert Nettleton" X-ReviewRequest-Repository: ambari --===============1059177952874173573== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37678/#review96052 ----------------------------------------------------------- Ship it! Ship It! - Robert Nettleton On Aug. 21, 2015, 1:45 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37678/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2015, 1:45 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Robert Levas, and Robert Nettleton. > > > Bugs: AMBARI-12850 > https://issues.apache.org/jira/browse/AMBARI-12850 > > > Repository: ambari > > > Description > ------- > > When performing a downgrade from HDP 2.3 to HDP 2.2, the web client can sometimes not show the Retry button in the event of a failure. The problem stems from two issues: > > - When retrying a stage with hosts not heartbeating, the entire stage is automatically aborted > - Task updates in stages is done in a non-atomic manner. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeGroupService.java ed97d66 > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 67379ee > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java 468315b > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 351bbec > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 0f05140 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 83c2c44 > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 1f8bf8d > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 63f015b > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java 4516b34 > > Diff: https://reviews.apache.org/r/37678/diff/ > > > Testing > ------- > > Tests run: 3159, Failures: 0, Errors: 0, Skipped: 25 > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 23:26 min > [INFO] Finished at: 2015-08-20T22:55:58-04:00 > [INFO] Final Memory: 48M/1069M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > > --===============1059177952874173573==--