Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 835BE18BA6 for ; Thu, 20 Aug 2015 17:22:22 +0000 (UTC) Received: (qmail 63197 invoked by uid 500); 20 Aug 2015 17:22:22 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 63155 invoked by uid 500); 20 Aug 2015 17:22:22 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 63135 invoked by uid 99); 20 Aug 2015 17:22:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Aug 2015 17:22:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BAF83F1EDB; Thu, 20 Aug 2015 17:22:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2904423696738838157==" MIME-Version: 1.0 Subject: Re: Review Request 37656: During upgrade, ALTER statements to change nullability of columns are not taking effect From: "Dmytro Sen" To: "Myroslav Papirkovskyy" , "Sumit Gupta" , "Vitalyi Brodetskyi" Cc: "Ambari" , "Dmytro Sen" Date: Thu, 20 Aug 2015 17:22:21 -0000 Message-ID: <20150820172221.12426.60597@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37656/ X-Sender: "Dmytro Sen" References: <20150820170520.29971.89634@reviews.apache.org> In-Reply-To: <20150820170520.29971.89634@reviews.apache.org> Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============2904423696738838157== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37656/ ----------------------------------------------------------- (Updated Авг. 20, 2015, 5:22 п.п.) Review request for Ambari, Myroslav Papirkovskyy, Sumit Gupta, and Vitalyi Brodetskyi. Bugs: AMBARI-12836 https://issues.apache.org/jira/browse/AMBARI-12836 Repository: ambari Description ------- I think that the alterColumn in the upgrade catalog may not be working. dbAccessor.alterColumn("viewinstanceproperty", new DBColumnInfo("value", String.class, 2000, null, true)); Performed a deployment of 1.6.1 and upgraded to 2.0.1. The column is still not nullable. ambari=> \d+ viewinstanceproperty; Table "ambari.viewinstanceproperty" Column | Type | Modifiers | Storage | Description --------------------+-------------------------+-----------+----------+------------- view_name | character varying(255) | not null | extended | view_instance_name | character varying(255) | not null | extended | name | character varying(255) | not null | extended | value | character varying(2000) | not null | extended | Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 19a516c ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 154645a ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/PostgresHelper.java 821b521 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java 595078f ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java b41b105 Diff: https://reviews.apache.org/r/37656/diff/ Testing ------- Unit tests passed Manually tested upgrade on PostreSQL, MySql, Oracle Thanks, Dmytro Sen --===============2904423696738838157==--