Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============5740667783343240855=="
MIME-Version: 1.0
Subject: Re: Review Request 36519: AMBARI-12349: Datanode failed to start when
 use
 non-default dfs.datanode.data.dir.mount.file or net.topology.script.file.name
From: "Alejandro Fernandez" <afernandez@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>
Cc: "Di Li" <dili@ca.ibm.com>, "Ambari" <dev@ambari.apache.org>
Date: Mon, 10 Aug 2015 21:55:57 -0000
Message-ID: <20150810215557.1374.59139@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
References: <20150810212852.1375.48893@reviews.apache.org>
In-Reply-To: <20150810212852.1375.48893@reviews.apache.org>
Reply-To: "Alejandro Fernandez" <afernandez@hortonworks.com>

--===============5740667783343240855==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Aug. 10, 2015, 9:28 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/rack_awareness.py, line 28
> > <https://reviews.apache.org/r/36519/diff/2/?file=1036614#file1036614line28>
> >
> >     Shouldn't use "dir" as a variable name since it's already a function name.

Thanks, is this meant for trunk and 2.1.1?


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36519/#review94800
-----------------------------------------------------------


On Aug. 10, 2015, 9:52 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36519/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 9:52 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-12349
>     https://issues.apache.org/jira/browse/AMBARI-12349
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When configure hadoop from install wizard, set "File that stores mount point" or "net.topology.script.file.name" to a non default location, e.g
> 
> /etc/hadoop1/conf/dfs_data_dir_mount.hist
> /etc/hadoop1/conf/topology_script.py
> 
> install failed because datanode could not be start, with error message
> 
> Applying File['/etc/hadoop1/conf/topology_mappings.data'] failed, parent directory /etc/hadoop1/conf doesn't exist
> 
> 
> This is because rack_awareness.py only handles the creation of the file but not the parent directory. Default value doesn't have this problem because the directory /etc/hadoop/conf was created in yum install.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/rack_awareness.py 6b0bff6 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py df39d2f 
> 
> Diff: https://reviews.apache.org/r/36519/diff/
> 
> 
> Testing
> -------
> 
> unit test: test_hook_refresh_topology_custom_directories (test_before_start.TestHookBeforeStart) ... ok
> 
> 
> Thanks,
> 
> Di Li
> 
>


--===============5740667783343240855==--