Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============5827220943595342606=="
MIME-Version: 1.0
Subject: Re: Review Request 37264: EclipseLink stdout Log Statements Fill Up
 Disk Space
From: "Nate Cole" <ncole@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>, "Sid Wagle" <swagle@hortonworks.com>,
 "Sumit Mohanty" <smohanty@hortonworks.com>
Cc: "Jonathan Hurley" <jhurley@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Mon, 10 Aug 2015 14:40:23 -0000
Message-ID: <20150810144023.1374.8822@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Nate Cole" <noreply@reviews.apache.org>
References: <20150810124700.1375.91803@reviews.apache.org>
In-Reply-To: <20150810124700.1375.91803@reviews.apache.org>
Reply-To: "Nate Cole" <ncole@hortonworks.com>

--===============5827220943595342606==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37264/#review94741
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Aug. 10, 2015, 8:46 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37264/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 8:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-12685
>     https://issues.apache.org/jira/browse/AMBARI-12685
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> EclipseLink's default logger logs to standard output. Since Ambari redirects stdout to a file, this means that all EclipseLink statements are captured in {{ambari-server.out}}.
> 
> On some systems with latency problems, EclipseLink will log retry attempts. Since this log is not rolling, it can fill up the disk.
> 
> There is no log4j bridge for EclipseLink. This Jira will track the creation of an slf4j bridge that will log all SQL statements to a separate, rolling logger.
> 
> 
> Diffs
> -----
> 
>   ambari-server/conf/unix/log4j.properties f619c6c 
>   ambari-server/conf/windows/log4j.properties 607cdf9 
>   ambari-server/src/main/conf/log4j.properties 6d53ca3 
>   ambari-server/src/main/java/org/apache/ambari/server/logging/EclipseLinkLogger.java PRE-CREATION 
>   ambari-server/src/main/resources/META-INF/persistence.xml deb30bb 
> 
> Diff: https://reviews.apache.org/r/37264/diff/
> 
> 
> Testing
> -------
> 
> Verified new logger file created and is rolling. Examples of bridged log statements:
> 
> [EL Debug]: 2015-08-08 22:17:34.305--ServerSession(1653567754)--Connection(2013352132)--Thread(Thread[qtp-ambari-agent-57,5,main])-- SELECT definition_id, cluster_id, component_name, definition_name, description, ENABLED, HASH, ignore_host, label, schedule_interval, scope, service_name, alert_source, source_type FROM alert_definition WHERE (((service_name = ?) AND (component_name = ?)) AND (cluster_id = ?))
> 	bind => [YARN, RESOURCEMANAGER, 2]
> [EL Debug]: 2015-08-08 22:17:34.306--ServerSession(1653567754)--Connection(761406242)--Thread(Thread[qtp-ambari-agent-57,5,main])-- SELECT definition_id, cluster_id, component_name, definition_name, description, ENABLED, HASH, ignore_host, label, schedule_interval, scope, service_name, alert_source, source_type FROM alert_definition WHERE (((service_name = ?) AND (component_name = ?)) AND (cluster_id = ?))
> 	bind => [ZOOKEEPER, ZOOKEEPER_SERVER, 2]
> [EL Debug]: 2015-08-08 22:17:34.307--ServerSession(1653567754)--Connection(941036240)--Thread(Thread[qtp-ambari-agent-57,5,main])-- SELECT definition_id, cluster_id, component_name, definition_name, description, ENABLED, HASH, ignore_host, label, schedule_interval, scope, service_name, alert_source, source_type FROM alert_definition WHERE ((((service_name IN (?,?,?,?)) AND (scope = ?)) AND (cluster_id = ?)) AND (component_name IS NULL))
> 	bind => [ZOOKEEPER, MAPREDUCE2, HDFS, YARN, SERVICE, 2]
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


--===============5827220943595342606==--