Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8971469515661147275=="
MIME-Version: 1.0
Subject: Review Request 37185: Ambari is overwriting the content of the
 topology script, even custom
From: "Andrew Onischuk" <aonishuk@hortonworks.com>
To: "Dmytro Sen" <dsen@hortonworks.com>
Cc: "Andrew Onischuk" <aonishuk@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Thu, 06 Aug 2015 14:12:23 -0000
Message-ID: <20150806141223.11504.96047@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Andrew Onischuk" <noreply@reviews.apache.org>
Reply-To: "Andrew Onischuk" <aonishuk@hortonworks.com>

--===============8971469515661147275==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37185/
-----------------------------------------------------------

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-12662
    https://issues.apache.org/jira/browse/AMBARI-12662


Repository: ambari


Description
-------

Ambari is overwriting the contents of whatever net.topology.script.file.name
is set to. This makes it impossible for a user to manage topology scripts on
their own (if they have an existing script, it keeps getting blown over)

<https://github.com/apache/ambari/blob/trunk/ambari-
server/src/main/resources/stacks/HDP/2.0.6/hooks/before-
START/scripts/params.py#L197>

Regardless if net.topology.script.file.name is set, Ambari should only manage
/etc/hadoop/conf/topology.py and NOT read the net.topology.script.file.name
property and overwrite that file's content. If a user chooses to manage their
own topology script and set that property accordingly, they should be ok doing
that and Ambari should not touch it.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 3ddefe3 

Diff: https://reviews.apache.org/r/37185/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


--===============8971469515661147275==--