ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-12868) Improve calls to the localStorage
Date Tue, 25 Aug 2015 14:12:45 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711329#comment-14711329
] 

Hudson commented on AMBARI-12868:
---------------------------------

FAILURE: Integrated in Ambari-branch-2.1 #418 (See [https://builds.apache.org/job/Ambari-branch-2.1/418/])
AMBARI-12868. Improve calls to the localStorage (onechiporenko) (onechiporenko: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=b5018a48b930ded6e5f0c480834451ab9e1677c8)
* ambari-web/app/controllers/main/service/add_controller.js
* ambari-web/app/controllers/installer.js
* ambari-web/app/controllers/main/host/add_controller.js
* ambari-web/app/controllers/wizard.js
* ambari-web/app/controllers/wizard/step7_controller.js
* ambari-web/app/utils/db.js


> Improve calls to the localStorage
> ---------------------------------
>
>                 Key: AMBARI-12868
>                 URL: https://issues.apache.org/jira/browse/AMBARI-12868
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-web
>    Affects Versions: 2.1.1
>            Reporter: Oleg Nechiporenko
>            Assignee: Oleg Nechiporenko
>             Fix For: 2.1.2
>
>         Attachments: AMBARI-12868.patch, AMBARI-12868_2.patch
>
>
> methods like {{setDBProperty}} and {{getDBProperty}} work slow, if are used several times
one after another. Example:
> {code:javascript}
> var a = this.getDBProperty('a');
> var b = this.getDBProperty('b');
> var c = this.getDBProperty('c');
> {code}
> Each getDBProperty-call does {{localStorage.getObject}} which may be slow if readable
object is too big (it may take 100-150 ms). So, it's better to read list of values with one
call, like:
> {code:javascript}
> this.getDBProperties(['a', 'b', 'c']);
> {code}
> And same for {{setDBProperties}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message