ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jayush Luniya" <jlun...@hortonworks.com>
Subject Re: Review Request 37953: SQLA: add property validation check for BP oozie/hive, about SQLA should be available only for stack 2.3+
Date Mon, 31 Aug 2015 18:56:35 GMT


> On Aug. 31, 2015, 6:39 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java,
line 115
> > <https://reviews.apache.org/r/37953/diff/1/?file=1060321#file1060321line115>
> >
> >     We should check for equal to or higher than 2.3.2 and type HDP. Other stacks
may have different version and type combination for the same feature.

Please dont use parseFloat as we have logic to explicitly replace stack versions based on
function being called in white labeling. Use something like the following for version check.
Also as Sumit mentioned we should check maintainence release version. 

ambari/ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
    # some versions of HDP don't need the lzo compression libraries
    target_version_needs_compression_libraries = compare_versions(
      format_hdp_stack_version(params.version), '2.2.1.0') >= 0


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37953/#review97118
-----------------------------------------------------------


On Aug. 31, 2015, 3:12 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37953/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 3:12 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
70d1907 
> 
> Diff: https://reviews.apache.org/r/37953/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message