ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 37902: Upgrade Orchestration To Skip Unhealthy Hosts
Date Fri, 28 Aug 2015 19:40:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37902/#review96911
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java (lines
204 - 205)
<https://reviews.apache.org/r/37902/#comment152596>

    Not sure if the !sc.isMasterComponent() should be removed.  I saw the new JIRA for running
pre-req before orchestration (which is fine), but in the meantime we may want masters to get
scheduled and let them fail appropriately.  I thought all along we had to have masters up,
but slaves/clients could be skipped.


- Nate Cole


On Aug. 28, 2015, 3:21 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37902/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 3:21 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-12924
>     https://issues.apache.org/jira/browse/AMBARI-12924
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When creating the various stages and tasks during the initial upgrade orchestration,
hosts that are unhealthy will be skipped entirely. Components and clients on these hosts will
not be a part of the upgrade, regardless of whether they contain slave or client components.
If, during the course up the upgrade, a host is taken out of maintenance mode, it will not
be inserted into the existing orchestration.
> 
> The upgrade packs can also define the hosts that a specific execution task can be scheduled
to run on. This type of dynamic host role command creation is only done at the time an upgrade
orchestration is schedule. For tasks that are schedule to run on "all" hosts, the hosts that
are schedule should also not contain those which are in maintenance mode.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/HostsType.java 55313d5 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java
ef75d38 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
ad84210 
>   ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 6267f53

> 
> Diff: https://reviews.apache.org/r/37902/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message