ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 37682: [Preview] Stop-and-Start Upgrade: Move Configs out of Upgrade Pack
Date Thu, 27 Aug 2015 15:08:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37682/
-----------------------------------------------------------

(Updated Aug. 27, 2015, 3:08 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate
Cole.


Changes
-------

Since it going to be a massive change, it would be great to get early feedback. Code is not
complete (still full of TODOs and does not even build)


Summary (updated)
-----------------

[Preview] Stop-and-Start Upgrade: Move Configs out of Upgrade Pack


Bugs: AMBARI-12700
    https://issues.apache.org/jira/browse/AMBARI-12700


Repository: ambari


Description (updated)
-------

The configs need to move out of the Upgrade Packs and into their own file.
This will make it easier to maintain, and clearer since there will not be any dups.

Since it is going to be a massive change, it would be great to get early feedback. Code is
not complete (still full of TODOs and does not even build)


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 4afa9b0

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
fa743be 
  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
c717582 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionDirectory.java
8f81b5a 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 89c10c6 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 4b88aff 
  ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 2aa89cc 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 3e25d01 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradeConfigChangesDescriptor.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
8361ea6 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java
8361ea6 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 9b7848f 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java
93e29b5 
  ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java f7898ee

  ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java a73775f

  ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade-config-changes-2.2.xml
PRE-CREATION 

Diff: https://reviews.apache.org/r/37682/diff/


Testing (updated)
-------

just published preview of changes


Thanks,

Dmitro Lisnichenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message