ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitiraj Rathore" <>
Subject Review Request 37792: Ambari File Browser view - Downloading a directory always creates a zip with name
Date Wed, 26 Aug 2015 09:37:57 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.

Bugs: AMBARI-12877

Repository: ambari


Earlier : 
Downloaded zip file is always named

In this Patch :
When single file/ folder is downloaded then zip is named based on that file (eg.
or If multiples files / folders are  downloaded then the zip is named as itself.

Changes in Patch: 
Earlier he file ambari/contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/
was hardcoding the name of the zip as in the HTTP header "Content-Disposition".
Now first we check the number of entries in DownloadRequest.entries and if it is one then
we name the zip after the name of this file or folder otherwise the zip is still named as





The unit test file ambari/contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/
has been updated to add one more test which checks for 5 combinations for file/folder downloads
and if the name of zip file comes as expected or not.

Manual UI test has been done and found to work as expected


Nitiraj Rathore

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message