ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 37393: Hive alert on secure cluster
Date Wed, 12 Aug 2015 13:43:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37393/#review95084
-----------------------------------------------------------

Ship it!


Ship It!


ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py
(line 174)
<https://reviews.apache.org/r/37393/#comment149901>

    This should be unnecessary since the absolute path to `kinit` is determined in `get_kinit_path`.
 But I don't think it is hurting anything.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py
(lines 178 - 179)
<https://reviews.apache.org/r/37393/#comment149903>

    Would it be possible to use `curl_krb_request` here?  It handles this type of scenario
well for web-based alert checks... see resource_management/libraries/functions/curl_krb_request.py:51



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py
(lines 199 - 200)
<https://reviews.apache.org/r/37393/#comment149904>

    Would it be possible to use `curl_krb_request` here?  It handles this type of scenario
well for web-based alert checks... see resource_management/libraries/functions/curl_krb_request.py:51


- Robert Levas


On Aug. 12, 2015, 9:01 a.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37393/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2015, 9:01 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmytro Sen.
> 
> 
> Bugs: AMBARI-12740
>     https://issues.apache.org/jira/browse/AMBARI-12740
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Steps:
> 
> Deploy cluster with Hive.
> Enable Security.
> 
> Result: Hive service has critical aler
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py
3d0e14c 
> 
> Diff: https://reviews.apache.org/r/37393/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed!
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message