ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Re: Review Request 37146: Create a Caching layer that provides sliding window behavior for metric requests to Ambari
Date Thu, 06 Aug 2015 23:59:11 GMT


> On Aug. 6, 2015, 10:33 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java,
line 264
> > <https://reviews.apache.org/r/37146/diff/2/?file=1033318#file1033318line264>
> >
> >     What happens on other types of exceptions?

Adding specialization for returning only on SocketTimeout in next revision of the patch, all
other exception still proceed with making remote calls for other metrics.


> On Aug. 6, 2015, 10:33 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheProvider.java,
line 60
> > <https://reviews.apache.org/r/37146/diff/2/?file=1033324#file1033324line60>
> >
> >     Should this be a constant?

Never going to be reused, this avoid annoying log message checking for newer versions of cache.


- Sid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37146/#review94454
-----------------------------------------------------------


On Aug. 6, 2015, 5:56 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37146/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 5:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Jaimin Jetly, Mahadev Konar,
and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-12654
>     https://issues.apache.org/jira/browse/AMBARI-12654
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Initial review requeted.
> 
> Objectives:
> -    In-memory caching of timeseries data for 1 hour queries.
> -    Support of service and dashboard metrics only
> -    Cache refresh is for a small segment of data vs requesting 1 hour data every time.
> -    On demand cache with sliding window implementation
> -    Zero/Null padding data does not appear in the cache
> -    Cache functionality can be turned on / off using config knob
> -    Caching policy is a cache-as-sor (Cache as System of Record), all queries for Service
Metrics will be returned from cache if caching is enabled and query window fits Cache timeseries
window, example 1 hour.
> -    Host metric queries will still goto AMS, this prevents host specific data to be
cached. This decision is based on usage/access pattern from Ambari web UI.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetrics.java
383079a 
>   ambari-server/pom.xml 98b1d2e 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
87cc7a4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
17b6d4a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
a7f206a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 5644ca5

>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
e048ec5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
380a0fe 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
3a6d30b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TemporalInfoImpl.java
2ffe984 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java
9fa9ca4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java
57a8e7d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProvider.java
5399436 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProviderProxy.java
a92cb37 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java
d5f415a 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostComponentPropertyProvider.java
8ee2acb 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostPropertyProvider.java
ca9d685 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
6667134 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java
a095206 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineAppMetricCacheKey.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricsCacheValue.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java
b8e0596 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
c8007c8 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProviderTest.java
3ee64fa 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37146/diff/
> 
> 
> Testing
> -------
> 
> Unit tests pass. Manual testing in progress.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message