ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 36995: Simulate Ambari Agents to test 3k Node Cluster
Date Wed, 05 Aug 2015 11:25:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36995/#review94225
-----------------------------------------------------------

Ship it!



contrib/agent-simulator/cluster.py (line 460)
<https://reviews.apache.org/r/36995/#comment148777>

    can check == False instead of using "is"



contrib/agent-simulator/example/config.ini (line 27)
<https://reviews.apache.org/r/36995/#comment148783>

    Great, thanks for adding this config file



contrib/agent-simulator/launcher_cluster.py (line 101)
<https://reviews.apache.org/r/36995/#comment148782>

    Cool



contrib/agent-simulator/launcher_cluster.py (line 256)
<https://reviews.apache.org/r/36995/#comment148781>

    Nice



contrib/agent-simulator/log.py (line 35)
<https://reviews.apache.org/r/36995/#comment148780>

    May be better to use os.linesep, not a big deal



contrib/agent-simulator/vm.py (line 120)
<https://reviews.apache.org/r/36995/#comment148779>

    Does this need to know about centos7?


- Alejandro Fernandez


On July 31, 2015, 8:05 p.m., Pengcheng Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36995/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 8:05 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-12339
>     https://issues.apache.org/jira/browse/AMBARI-12339
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> add comments, document, add Weave DNS, add host network setup script, change cluster
configuration, add new Docker image install methods
> add Ambari-agents inside VM, fix network issued, add SSH to Docker container, automatic
network configuration, new command line interface
> 
> 
> Diffs
> -----
> 
>   contrib/agent-simulator/Docker/Dockerfile d22435a 
>   contrib/agent-simulator/Docker/__init__.py 62aeca1 
>   contrib/agent-simulator/Docker/ambari_agent_start.sh 4ba2361 
>   contrib/agent-simulator/Docker/launcher_agent.py 5ff008d 
>   contrib/agent-simulator/Linux/CentOS7/docker_install.sh 033c2b9 
>   contrib/agent-simulator/Linux/CentOS7/set_docker_partition.sh PRE-CREATION 
>   contrib/agent-simulator/Linux/CentOS7/weave_install.sh 6788184 
>   contrib/agent-simulator/Linux/Ubuntu12/docker_install.sh 220f1a4 
>   contrib/agent-simulator/Linux/Ubuntu12/weave_install.sh 332488d 
>   contrib/agent-simulator/README.md PRE-CREATION 
>   contrib/agent-simulator/cluster.py 55c3c44 
>   contrib/agent-simulator/config.py 20cc8de 
>   contrib/agent-simulator/config/config.ini a3afa33 
>   contrib/agent-simulator/data.py PRE-CREATION 
>   contrib/agent-simulator/docker.py e397c4b 
>   contrib/agent-simulator/docker_image/Yum_Dockerfile PRE-CREATION 
>   contrib/agent-simulator/docker_image/__init__.py PRE-CREATION 
>   contrib/agent-simulator/docker_image/ambari_agent_install.sh PRE-CREATION 
>   contrib/agent-simulator/docker_image/ambari_agent_start.sh PRE-CREATION 
>   contrib/agent-simulator/docker_image/launcher_agent.py PRE-CREATION 
>   contrib/agent-simulator/docker_image/package_list.txt PRE-CREATION 
>   contrib/agent-simulator/docker_image/ssh_service/run.sh PRE-CREATION 
>   contrib/agent-simulator/docker_image/ssh_service/set_root_pw.sh PRE-CREATION 
>   contrib/agent-simulator/example/config.ini PRE-CREATION 
>   contrib/agent-simulator/launcher_ambari_server.py PRE-CREATION 
>   contrib/agent-simulator/launcher_cluster.py 0a7cbe0 
>   contrib/agent-simulator/launcher_docker.py 48e8fac 
>   contrib/agent-simulator/launcher_service_server.py PRE-CREATION 
>   contrib/agent-simulator/log.py PRE-CREATION 
>   contrib/agent-simulator/network/DNS_editor.py PRE-CREATION 
>   contrib/agent-simulator/network/set_ambari_server_network.sh PRE-CREATION 
>   contrib/agent-simulator/network/set_host_network.sh PRE-CREATION 
>   contrib/agent-simulator/server/ambari_server_install.sh PRE-CREATION 
>   contrib/agent-simulator/server/ambari_server_reset_data.sh PRE-CREATION 
>   contrib/agent-simulator/server/ambari_server_start.sh PRE-CREATION 
>   contrib/agent-simulator/server_setup.sh 3b499aa 
>   contrib/agent-simulator/tips.txt 207177d 
>   contrib/agent-simulator/vm.py 90de4de 
> 
> Diff: https://reviews.apache.org/r/36995/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on Google Compute
> 
> 
> Thanks,
> 
> Pengcheng Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message