ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 36943: [Preview] RU- 2.3 - 2.3 + - NFS jars are not upgraded and refer to old version after the upgrade
Date Mon, 03 Aug 2015 11:16:43 GMT


> On July 31, 2015, 12:21 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py,
lines 48-50
> > <https://reviews.apache.org/r/36943/diff/1/?file=1025111#file1025111line48>
> >
> >     If this is true, then the upgrade pack for 2.2.x -> 2.2.y needs to be updated.
 If not, then this version check should be for 2.3.

You are right, I correctly added definitions for 2.3 stack, but missed boilerplate code change
here. NFS gateway has been added in HDP 2.3


> On July 31, 2015, 12:21 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml, line 140
> > <https://reviews.apache.org/r/36943/diff/1/?file=1025112#file1025112line140>
> >
> >     +1 for this comment.  Also, python says 2.2 and higher, so would need HDP-2.2
-> 2.2 upgrade pack change.

I think no, since NFS gateway has been added in HDP 2.3


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36943/#review93719
-----------------------------------------------------------


On July 30, 2015, 3:33 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36943/
> -----------------------------------------------------------
> 
> (Updated July 30, 2015, 3:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-12594
>     https://issues.apache.org/jira/browse/AMBARI-12594
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> RU- 2.3 - 2.3 + - NFS jars are not upgraded and refer to old version after the upgrade
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
d599b8c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 3dda481 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py 37dcb20 
> 
> Diff: https://reviews.apache.org/r/36943/diff/
> 
> 
> Testing
> -------
> 
> OK
> ----------------------------------------------------------------------
> Total run:808
> Total errors:0
> Total failures:0
> OK
> 
> Performing tests on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message