Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============5952330114471295499=="
MIME-Version: 1.0
Subject: Re: Review Request 36949: Blueprint deployments modified to force a
 full config refresh during deployment for each config type
From: "Robert Nettleton" <rnettleton@hortonworks.com>
To: "Mahadev Konar" <mahadev@apache.org>,
 "Myroslav Papirkovskyy" <mpapyrkovskyy@hortonworks.com>,
 "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Robert Nettleton" <rnettleton@hortonworks.com>
Date: Thu, 30 Jul 2015 21:25:53 -0000
Message-ID: <20150730212553.1539.12105@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Robert Nettleton" <noreply@reviews.apache.org>
References: <20150730202619.1539.25333@reviews.apache.org>
In-Reply-To: <20150730202619.1539.25333@reviews.apache.org>
Reply-To: "Robert Nettleton" <rnettleton@hortonworks.com>

--===============5952330114471295499==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36949/
-----------------------------------------------------------

(Updated July 30, 2015, 9:25 p.m.)


Review request for Ambari, Jonathan Hurley, Mahadev Konar, Myroslav Papirkovskyy, and Sumit Mohanty.


Changes
-------

Uploaded version 2 of this patch, to address reviewer's concerns.


Bugs: AMBARI-12595
    https://issues.apache.org/jira/browse/AMBARI-12595


Repository: ambari


Description
-------

This patch resolves AMBARI-12595.  

In large-scale clusters, there are some intermittent failures in Blueprint deployments that occur due to un-resolved configuration.  The Blueprints processor should refresh the configuration on each ExecutionCommand instance, prior to sending these commands to nodes in the cluster.  

This patch implements the following:

1. Adds an overloaded method to ExecutionCommandWrapper to handle the Blueprints-specific case where an ExecutionCommand should always refresh the configuration fully before further processing continues. 
2. Modifies the AmbariManagementControllerImpl.createHostAction() method to detect the case of a Blueprints deployment, and to call the new overloaded method in ExecutionCommandWrapper to ensure that the configuration for this command is fully refreshed.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java a775452 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 1f4e7cd 

Diff: https://reviews.apache.org/r/36949/diff/


Testing
-------

1. Deployed a 3-node HDFS HA cluster with this patch applied, and verified that the cluster was installed and started properly. 
2. Prior to merging this patch, I will run the full ambari-server unit test suite, and verify that it passes.


Thanks,

Robert Nettleton


--===============5952330114471295499==--