Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============6565515627561378236=="
MIME-Version: 1.0
Subject: Review Request 36917: Host check/clean-up logic should clean up new
 packages and folder names
From: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
To: "Andrew Onischuk" <aonishuk@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>
Cc: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Wed, 29 Jul 2015 17:07:57 -0000
Message-ID: <20150729170757.1539.35772@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Dmitro Lisnichenko" <noreply@reviews.apache.org>
Reply-To: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>

--===============6565515627561378236==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36917/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk and Nate Cole.


Bugs: AMBARI-12581
    https://issues.apache.org/jira/browse/AMBARI-12581


Repository: ambari


Description
-------

Few HDP-2.3 installation ran into problem when install performed on VMs that are not clean. One of the reported problem is:
Traceback (most recent call last):
  File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py", line 38, in <module>
    AfterInstallHook().execute()
  File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 218, in execute
    method(env)
  File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/hook.py", line 35, in hook
    link_configs(self.stroutfile)
  File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py", line 91, in link_configs
    _link_configs(k, json_version, v)
  File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py", line 156, in _link_configs
    conf_select.select("HDP", package, version)
  File "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/conf_select.py", line 241, in select
    shell.checked_call(get_cmd("set-conf-dir", package, version), logoutput=False, quiet=False, sudo=True)
  File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 70, in inner
    result = function(command, **kwargs)
  File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 92, in checked_call
    tries=tries, try_sleep=try_sleep)
  File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 140, in _call_wrapper
    result = _call(command, **kwargs_copy)
  File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", line 291, in _call
    raise Fail(err_msg)
resource_management.core.exceptions.Fail: Execution of 'conf-select set-conf-dir --package ranger-kms --stack-version 2.3.0.0-2557 --conf-version 0' returned 1. ranger-kms not installed or incorrect package name
AMBARI-12515 is looking into making conf-select call more robust but host-clean up script (along with host checkup) need to be modified to handle the new folders introduced under "/etc" as well as "/usr/hdp/current" or "/usr/hdp/version".
Suggestion from Nate Cole regarding cleaning up conf dirs.
cd /etc
remove accumulo ambari-* atlas hadoop-* hive* hive-* mahout phoenix ranger spark zookeeper falcon hadoop hbase kafka knox oozie ranger-* (ranger-admin, ranger-kms, ranger-usersync) slider sqoop storm pig flume hive-hcatalog
The host check script should be modified to include these folders in the report so that the cleanup script can clean it.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/HostInfo.py 385c758 
  ambari-server/src/main/resources/custom_actions/scripts/check_host.py 40bea98 

Diff: https://reviews.apache.org/r/36917/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [4.140s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.754s]
[INFO] Ambari Server ..................................... SUCCESS [1:10.901s]
[INFO] Ambari Agent ...................................... SUCCESS [16.487s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:34.779s
[INFO] Finished at: Wed Jul 29 20:05:08 EEST 2015
[INFO] Final Memory: 87M/1452M


Thanks,

Dmitro Lisnichenko


--===============6565515627561378236==--