Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 797EF17BBE for ; Mon, 27 Jul 2015 15:21:06 +0000 (UTC) Received: (qmail 38961 invoked by uid 500); 27 Jul 2015 15:21:06 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 38931 invoked by uid 500); 27 Jul 2015 15:21:06 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 38918 invoked by uid 99); 27 Jul 2015 15:21:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jul 2015 15:21:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 670B3D5645; Mon, 27 Jul 2015 15:21:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1505485383203000450==" MIME-Version: 1.0 Subject: Review Request 36848: Facter.py not using the hostname implementation and uses hostname -f instead From: "Andrew Onischuk" To: "Dmitro Lisnichenko" Cc: "Andrew Onischuk" , "Ambari" Date: Mon, 27 Jul 2015 15:21:05 -0000 Message-ID: <20150727152105.28760.86945@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Andrew Onischuk" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36848/ X-Sender: "Andrew Onischuk" Reply-To: "Andrew Onischuk" X-ReviewRequest-Repository: ambari --===============1505485383203000450== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36848/ ----------------------------------------------------------- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-12552 https://issues.apache.org/jira/browse/AMBARI-12552 Repository: ambari Description ------- Facter.py currently has it's own implementation instead of using hostname.py This failed in production. Making critical because it has the potential to hit us many more times ambari_agent - Facter.py - [5524] - root - WARNING - Could not get fqdn using /bin/hostname -f Diffs ----- ambari-agent/src/main/python/ambari_agent/Facter.py 20b0447 Diff: https://reviews.apache.org/r/36848/diff/ Testing ------- mvn clean test Thanks, Andrew Onischuk --===============1505485383203000450==--