Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8329021574748011582=="
MIME-Version: 1.0
Subject: Re: Review Request 35844: Update poms to target 1.7 and 1.6 JREs
From: "Jayush Luniya" <jluniya@hortonworks.com>
To: "Yusaku Sako" <yusaku@hortonworks.com>,
 "Jayush Luniya" <jluniya@hortonworks.com>,
 "Sid Wagle" <swagle@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>
Date: Mon, 13 Jul 2015 21:18:18 -0000
Message-ID: <20150713211818.17363.26727@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jayush Luniya" <noreply@reviews.apache.org>
References: <20150708172746.1572.24691@reviews.apache.org>
In-Reply-To: <20150708172746.1572.24691@reviews.apache.org>
Reply-To: "Jayush Luniya" <jluniya@hortonworks.com>

--===============8329021574748011582==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35844/#review91528
-----------------------------------------------------------


@Jonathan Halterman
The patch attached to the Apache JIRA is different to the patch attached here. Can you update the reviewboard request with the latest patch?

- Jayush Luniya


On July 8, 2015, 5:27 p.m., Jonathan Halterman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35844/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 5:27 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12134
>     https://issues.apache.org/jira/browse/AMBARI-12134
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The ambari parent pom is targeted towards Java 1.6 while ambari uses 1.7 APIs. The ambari metrics pom is targeted at java 1.5 (by default) while ambari-metrics uses 1.6 APIs. This causes basic compilation failures, depending on how you build the projects and what tools you use to work on them. AFAIK Ambari 2.1 and beyond are targeted at 1.7, so the Java versions in the POMs should be updated to reflect this.
> 
> Aside from changing the target version for the compiler plugin, some other dependencies had to be updated to more recent versions that support 1.7 compilation.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/pom.xml b4f4ed3 
>   pom.xml 47eac31 
> 
> Diff: https://reviews.apache.org/r/35844/diff/
> 
> 
> Testing
> -------
> 
> All tests pass!
> 
> 
> Thanks,
> 
> Jonathan Halterman
> 
>


--===============8329021574748011582==--