Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============3527200520748480625=="
MIME-Version: 1.0
Subject: Re: Review Request 36400: Widget display goes on and off at service
 dashboard for Number and Graph widgets using same metrics
From: "Yusaku Sako" <yusaku@hortonworks.com>
To: "Yusaku Sako" <yusaku@hortonworks.com>,
 "Srimanth Gunturi" <srimanth@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>, "Jaimin Jetly" <jaimin@hortonworks.com>
Date: Fri, 10 Jul 2015 19:55:32 -0000
Message-ID: <20150710195532.1572.52145@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Yusaku Sako" <noreply@reviews.apache.org>
References: <20150710195255.1573.16372@reviews.apache.org>
In-Reply-To: <20150710195255.1573.16372@reviews.apache.org>
Reply-To: "Yusaku Sako" <yusaku@hortonworks.com>

--===============3527200520748480625==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36400/#review91339
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On July 10, 2015, 7:52 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36400/
> -----------------------------------------------------------
> 
> (Updated July 10, 2015, 7:52 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12378
>     https://issues.apache.org/jira/browse/AMBARI-12378
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> Create any of Number/Gauge/Template widget with a specific metric of a component
> Use the same metric of the same component to create another widget with the Graph type
> Widget display will go on and off.
> This happens because UI aggregates all the metrics in the single call. When same metric is present with and without timesteps then BE returns either point in time value or temporal value
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/mixins/common/widgets/widget_mixin.js 961ce7d 
>   ambari-web/test/mixins/common/widget_mixin_test.js 1881d98 
> 
> Diff: https://reviews.apache.org/r/36400/diff/
> 
> 
> Testing
> -------
> 
> Tested the patch on the live cluster
> verified that all ambari-web unit tets passes with the patch:
> 
>   6663 tests complete (11 seconds)
>   90 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


--===============3527200520748480625==--