Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============2050530464542177263=="
MIME-Version: 1.0
Subject: Re: Review Request 36302: Ambari should not configure
 hbase.regionserver.global.memstore.upperLimit in HDP-2.3
From: "Sumit Mohanty" <smohanty@hortonworks.com>
To: "Andrew Onischuk" <aonishuk@hortonworks.com>,
 "Nate Cole" <ncole@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>,
 "Sumit Mohanty" <smohanty@hortonworks.com>
Date: Wed, 08 Jul 2015 19:56:02 -0000
Message-ID: <20150708195602.1572.70022@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sumit Mohanty" <noreply@reviews.apache.org>
References: <20150708165059.1572.74408@reviews.apache.org>
In-Reply-To: <20150708165059.1572.74408@reviews.apache.org>
Reply-To: "Sumit Mohanty" <smohanty@hortonworks.com>

--===============2050530464542177263==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36302/#review90978
-----------------------------------------------------------


ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/themes/theme.json (line 10)
<https://reviews.apache.org/r/36302/#comment144138>

    The bug title says "Ambari should not configure hbase.regionserver.global.memstore.upperLimit in HDP-2.3". Should we be adding these properties and add them to theme.json?


ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HBASE/configuration/hbase-site.xml (line 43)
<https://reviews.apache.org/r/36302/#comment144139>

    The bug title says "Ambari should not configure hbase.regionserver.global.memstore.upperLimit in HDP-2.3". Should we be adding these properties to hbase-site.xml for HDP-2.3?


- Sumit Mohanty


On July 8, 2015, 4:50 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36302/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 4:50 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-12224
>     https://issues.apache.org/jira/browse/AMBARI-12224
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HBase has deprecated hbase.regionserver.global.memstore.upperLimit and hbase.regionserver.global.memstore.lowerLimit for HDP-2.3 in favor of hbase.regionserver.global.memstore.size and hbase.regionserver.global.memstore.size.lower.limit.
> The slider called "% of RegionServer Allocated to Write Buffers" sets hbase.regionserver.global.memstore.size, while hbase.regionserver.global.memstore.upperLimit is in the advanced configuration section. This leaves two bugs:
> In HDP-2.2, the slider has no affect since HBase basically ignores the parameter.
> In HDP-2.3 the value set by the slider also has no affect since the deprecated values set take precedence.
> One solution is to get rid of hbase.regionserver.global.memstore.upperLimit and hbase.regionserver.global.memstore.lowerLimit in advanced settings in Ambari, and make the slider configuration to use hbase.regionserver.global.memstore.upperLimit in HDP-2.2 and hbase.regionserver.global.memstore.size in HDP-2.3. Rolling upgrade can convert these settings.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HBaseConfigCalculation.java PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/themes/theme.json 53da86d 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml c5fb156 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/hbase-site.xml 12cd44b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/metainfo.xml 921a225 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/themes/theme.json PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HBASE/themes/theme.json 1808809 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HBASE/configuration/hbase-site.xml 43f872a 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HBASE/metainfo.xml aa169df 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HBASE/themes/theme.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36302/diff/
> 
> 
> Testing
> -------
> 
> manual checks
> Tests in error: 
>   UpgradeResourceProviderTest.testCreatePartialDowngrade:428 ? NullPointer
> 
> Tests run: 3111, Failures: 0, Errors: 1, Skipped: 28
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [6.409s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [3.909s]
> [INFO] Ambari Server ..................................... FAILURE [1:16:42.534s]
> [INFO] Ambari Agent ...................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:16:57.150s
> [INFO] Finished at: Wed Jul 08 10:34:40 UTC 2015
> [INFO] Final Memory: 39M/826M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


--===============2050530464542177263==--