Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0509218E5F for ; Mon, 6 Jul 2015 17:20:47 +0000 (UTC) Received: (qmail 67833 invoked by uid 500); 6 Jul 2015 17:20:44 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 67810 invoked by uid 500); 6 Jul 2015 17:20:44 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 67659 invoked by uid 99); 6 Jul 2015 17:20:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jul 2015 17:20:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 03128B31C1; Mon, 6 Jul 2015 17:20:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4359198569154581112==" MIME-Version: 1.0 Subject: Re: Review Request 36150: RU PreCheck to exclude Slaves From: "Alejandro Fernandez" To: "Alejandro Fernandez" , "Jonathan Hurley" Cc: "Nate Cole" , "Ambari" Date: Mon, 06 Jul 2015 17:20:43 -0000 Message-ID: <20150706172043.8753.16833@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alejandro Fernandez" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36150/ X-Sender: "Alejandro Fernandez" References: <20150702225051.13308.95198@reviews.apache.org> In-Reply-To: <20150702225051.13308.95198@reviews.apache.org> Reply-To: "Alejandro Fernandez" X-ReviewRequest-Repository: ambari --===============4359198569154581112== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36150/#review90503 ----------------------------------------------------------- ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java (line 93) Comment should say "equal to or more than 1" - Alejandro Fernandez On July 2, 2015, 10:50 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36150/ > ----------------------------------------------------------- > > (Updated July 2, 2015, 10:50 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-12268 > https://issues.apache.org/jira/browse/AMBARI-12268 > > > Repository: ambari > > > Description > ------- > > * Modify the service-up-check to make a calculation for slaves whose cardinality is "1+" - other slaves should be checked, but the "1+" are things like DN, NM, RS, Supervisors. > * Also added a stack trace to a log we rarely get, but is really annoying. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java 296624d > ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java ff50bc9 > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java 87cb8a9 > > Diff: https://reviews.apache.org/r/36150/diff/ > > > Testing > ------- > > Tests run: 3106, Failures: 0, Errors: 0, Skipped: 28 > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 29:22 min > [INFO] Finished at: 2015-07-02T18:21:33-04:00 > [INFO] Final Memory: 32M/1186M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > > --===============4359198569154581112==--