Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7D7D718A49 for ; Mon, 6 Jul 2015 15:44:46 +0000 (UTC) Received: (qmail 6540 invoked by uid 500); 6 Jul 2015 15:44:46 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 6505 invoked by uid 500); 6 Jul 2015 15:44:46 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 6488 invoked by uid 99); 6 Jul 2015 15:44:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jul 2015 15:44:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A01DAAA40E; Mon, 6 Jul 2015 15:44:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0313265498323600266==" MIME-Version: 1.0 Subject: Re: Review Request 36190: Alerts: HDFS Capacity Utilization Alert Always Shows 0% From: "Tom Beerbower" To: "Nate Cole" , "Tom Beerbower" Cc: "Jonathan Hurley" , "Ambari" Date: Mon, 06 Jul 2015 15:44:44 -0000 Message-ID: <20150706154444.8753.45925@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Tom Beerbower" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36190/ X-Sender: "Tom Beerbower" References: <20150706035818.8752.62062@reviews.apache.org> In-Reply-To: <20150706035818.8752.62062@reviews.apache.org> Reply-To: "Tom Beerbower" X-ReviewRequest-Repository: ambari --===============0313265498323600266== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36190/#review90487 ----------------------------------------------------------- Ship it! Ship It! - Tom Beerbower On July 6, 2015, 3:58 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36190/ > ----------------------------------------------------------- > > (Updated July 6, 2015, 3:58 a.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-12285 > https://issues.apache.org/jira/browse/AMBARI-12285 > > > Repository: ambari > > > Description > ------- > > Some alerts, such as the HDFS capacity or DataNode capacity always show a utilization of 0%, preventing any alert from triggering since the state is always OK. > > This is due to integer division which causes the float percentage to be rounded down to 0. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py fea2f6c > ambari-agent/src/test/python/ambari_agent/TestAlerts.py 4570842 > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 47ddd7a > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 4e62eab > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/alerts.json cee8209 > > Diff: https://reviews.apache.org/r/36190/diff/ > > > Testing > ------- > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 22.140 s > [INFO] Finished at: 2015-07-05T22:34:46-04:00 > [INFO] Final Memory: 13M/245M > [INFO] ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > > --===============0313265498323600266==--