Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9D01418022 for ; Mon, 6 Jul 2015 10:59:56 +0000 (UTC) Received: (qmail 90279 invoked by uid 500); 6 Jul 2015 10:59:56 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 90244 invoked by uid 500); 6 Jul 2015 10:59:56 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 90229 invoked by uid 99); 6 Jul 2015 10:59:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jul 2015 10:59:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A68FF1DB699; Mon, 6 Jul 2015 10:59:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8122577874825190771==" MIME-Version: 1.0 Subject: Re: Review Request 36194: Schema version of Ambari updated before actual end of DML queries (if a problem is encountered during upgrade, fixing issues and running it again did not drop obsolete columns) From: "Dmitro Lisnichenko" To: "Dmitro Lisnichenko" Cc: "Vitalyi Brodetskyi" , "Ambari" Date: Mon, 06 Jul 2015 10:59:54 -0000 Message-ID: <20150706105954.8752.23410@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmitro Lisnichenko" X-ReviewGroup: Ambari X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36194/ X-Sender: "Dmitro Lisnichenko" References: <20150706105258.8752.24043@reviews.apache.org> In-Reply-To: <20150706105258.8752.24043@reviews.apache.org> Reply-To: "Dmitro Lisnichenko" X-ReviewRequest-Repository: ambari --===============8122577874825190771== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36194/#review90465 ----------------------------------------------------------- Ship it! ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DerbyHelper.java (line 66) formatting - Dmitro Lisnichenko On July 6, 2015, 10:52 a.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36194/ > ----------------------------------------------------------- > > (Updated July 6, 2015, 10:52 a.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-12287 > https://issues.apache.org/jira/browse/AMBARI-12287 > > > Repository: ambari > > > Description > ------- > > The following was encountered while adding a host: > Caused by: Exception EclipseLink-4002 (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException > Internal Exception: java.sql.SQLException: Field 'desired_stack_version' doesn't have a default value > Error Code: 1364 > Call: INSERT INTO hostcomponentdesiredstate (admin_state, desired_state, maintenance_state, restart_required, security_ > state, host_id, cluster_id, service_name, component_name, desired_stack_id) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?) > bind => 10 parameters bound > Query: InsertObjectQuery(org.apache.ambari.server.orm.entities.HostComponentStateEntity@c448c71c) > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DerbyHelper.java c012a77 > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 8c7f831 > ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 687569b > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog.java 976cc99 > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java 47ddd7a > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeTest.java 9e516e7 > > Diff: https://reviews.apache.org/r/36194/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > > --===============8122577874825190771==--