ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 36861: Completion of service metrics API call should not block login loading bar progress.
Date Tue, 28 Jul 2015 21:43:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36861/
-----------------------------------------------------------

(Updated July 28, 2015, 9:43 p.m.)


Review request for Ambari, Srimanth Gunturi and Yusaku Sako.


Changes
-------

New revision of the patch changes the dashboard widget and service summary text to show spinner
and "Loading..." text respectively instaed of n/a or no data. 
Removes "Loading" text that appears on host page loading.
The patch has been tested with NameNode HA wizard.


Bugs: AMBARI-12557
    https://issues.apache.org/jira/browse/AMBARI-12557


Repository: ambari


Description
-------

After the patch, there will be 3 API calls that will be made as part of the loading progress
bar:
# http://c6407.ambari.apache.org:8080/api/v1/stacks/HDP/versions/2.3/services?fields=StackServices/*,components/*,components/dependencies/Dependencies/scope,artifacts/Artifacts/artifact_name
# http://c6407.ambari.apache.org:8080/api/v1/clusters/c1/stack_versions?fields=*,repository_versions/*,repository_versions/operating_systems/repositories/*
# http://c6407.ambari.apache.org:8080/api/v1/clusters/c1/services?fields=ServiceInfo/state,ServiceInfo/maintenance_state,components/ServiceComponentInfo/component_name&minimal_response=true


After the patch login to the dashboard takes ~2.5 seconds on 800 node cluster. (Important:
Note that web resources should be gzipped and persist endpoint should not have stale data.
Otherwise results can greatly vary).

Apart from perf improvement, this patch also includes following:
1) Removal of unused JS files (related to service dashboard)
2) An existing bug in 2.1.0 release where browser refresh on service->configs page navigates
to service->summary page


Diffs (updated)
-----

  ambari-web/app/app.js 0683818 
  ambari-web/app/controllers/global/cluster_controller.js b16de85 
  ambari-web/app/controllers/main/admin/kerberos.js 2bc7cfd 
  ambari-web/app/controllers/main/host/details.js 29d66b0 
  ambari-web/app/controllers/main/service/item.js ea7488e 
  ambari-web/app/data/service_graph_config.js e660b5f 
  ambari-web/app/mappers/components_state_mapper.js 0a960c4 
  ambari-web/app/mappers/service_mapper.js d340d22 
  ambari-web/app/mappers/service_metrics_mapper.js 78d37eb 
  ambari-web/app/messages.js b5b9c55 
  ambari-web/app/mixins/common/widgets/widget_mixin.js c07e23e 
  ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 2a597b2 
  ambari-web/app/models/host_component.js 93804a3 
  ambari-web/app/routes/add_service_routes.js c454364 
  ambari-web/app/routes/main.js 1b17ab8 
  ambari-web/app/routes/reassign_master_routes.js 7d5069e 
  ambari-web/app/styles/application.less fc2c687 
  ambari-web/app/templates/main/dashboard/widgets/hbase_links.hbs 66d5d23 
  ambari-web/app/templates/main/dashboard/widgets/pie_chart.hbs 6af3a01 
  ambari-web/app/templates/main/dashboard/widgets/simple_text.hbs 4b14113 
  ambari-web/app/templates/main/dashboard/widgets/uptime.hbs 9ea9e8b 
  ambari-web/app/templates/main/dashboard/widgets/yarn_links.hbs 7cad4f1 
  ambari-web/app/templates/main/service/info/summary.hbs eee8c49 
  ambari-web/app/templates/main/service/services/hbase.hbs b728abe 
  ambari-web/app/templates/main/service/services/hdfs.hbs 1cbd082 
  ambari-web/app/templates/main/service/services/storm.hbs 18b84d5 
  ambari-web/app/templates/main/service/services/yarn.hbs c29bbcc 
  ambari-web/app/views.js d796441 
  ambari-web/app/views/main/dashboard/widget.js b63e89f 
  ambari-web/app/views/main/dashboard/widgets/links_widget.js 1aabdcb 
  ambari-web/app/views/main/dashboard/widgets/namenode_cpu.js 5559a94 
  ambari-web/app/views/main/host/details/host_component_views/datanode_view.js b8f3c7d 
  ambari-web/app/views/main/host/summary.js 06e3d09 
  ambari-web/app/views/main/service/info/metrics/hbase/cluster_requests.js 78d5f6f 
  ambari-web/app/views/main/service/info/metrics/hbase/hlog_split_size.js 15d6fcb 
  ambari-web/app/views/main/service/info/metrics/hbase/hlog_split_time.js 01e7a28 
  ambari-web/app/views/main/service/info/metrics/hbase/regionserver_queuesize.js 9136de0 
  ambari-web/app/views/main/service/info/metrics/hbase/regionserver_regions.js 421bc08 
  ambari-web/app/views/main/service/info/metrics/hbase/regionserver_rw_requests.js 7df350c

  ambari-web/app/views/main/service/info/metrics/hdfs/block_status.js c46ee2f 
  ambari-web/app/views/main/service/info/metrics/hdfs/file_operations.js ceae042 
  ambari-web/app/views/main/service/info/metrics/hdfs/gc.js a97e81a 
  ambari-web/app/views/main/service/info/metrics/hdfs/io.js eb12849 
  ambari-web/app/views/main/service/info/metrics/hdfs/jvm_heap.js bb9300b 
  ambari-web/app/views/main/service/info/metrics/hdfs/jvm_threads.js ae9118b 
  ambari-web/app/views/main/service/info/metrics/hdfs/rpc.js df5baaa 
  ambari-web/app/views/main/service/info/metrics/hdfs/space_utilization.js 42c7c06 
  ambari-web/app/views/main/service/info/metrics/yarn/allocated.js e7f922a 
  ambari-web/app/views/main/service/info/metrics/yarn/allocated_container.js 942d1b4 
  ambari-web/app/views/main/service/info/metrics/yarn/apps_current_states.js cf97ebd 
  ambari-web/app/views/main/service/info/metrics/yarn/apps_finished_states.js 0bcc489 
  ambari-web/app/views/main/service/info/metrics/yarn/gc.js 265a56d 
  ambari-web/app/views/main/service/info/metrics/yarn/jvm_heap.js 70fd89c 
  ambari-web/app/views/main/service/info/metrics/yarn/jvm_threads.js aeb8601 
  ambari-web/app/views/main/service/info/metrics/yarn/nms.js 14cc2a8 
  ambari-web/app/views/main/service/info/metrics/yarn/qmr.js 077df4b 
  ambari-web/app/views/main/service/info/metrics/yarn/rpc.js 1e4ecf4 
  ambari-web/app/views/main/service/info/summary.js 83e503f 
  ambari-web/app/views/main/service/services/hdfs.js d70b454 
  ambari-web/test/controllers/main/host/details_test.js f9c48cf 
  ambari-web/test/views/main/service/info/summary_test.js 7511cd3 

Diff: https://reviews.apache.org/r/36861/diff/


Testing
-------

Verified that all ambari-web unit tests passess with the patch:

  6678 tests complete (10 seconds)
  94 tests pending

Tested the ambari functionality that can be affected with the patch:
# Tested that browser refresh on any page of the deployed cluster does not break that page
# Add service wizard in kerbero and non-kerberos env
# Move master wizard (for RM)
# Browser refresh on host page, followed with adding datanode component to that host


Thanks,

Jaimin Jetly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message