ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 36890: Adding more debug logging to the Blueprint dynamic provisioning code
Date Tue, 28 Jul 2015 18:41:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36890/#review93324
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On July 28, 2015, 3:45 p.m., Robert Nettleton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36890/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 3:45 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-12567
>     https://issues.apache.org/jira/browse/AMBARI-12567
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch resolves AMBARI-12567.  
> 
> The new Blueprint provisioning code does not log much information during the cluster
deployment process.  This turns out to be a problem in failure conditions during large deployments.
 
> 
> This patch resolves this issue by adding more detailed logging to the TopologyManager,
and other classes in the Blueprints code.  In particular, the handling of mapping servers
to host groups is now logged in more detail, as is the timing between the configuration and
install/start phases of Blueprint deployment.  This should prove helpful when debugging large
cluster deployments with Blueprints.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
6bf563b 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java afd7711

>   ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java 423c503

>   ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
d1f2dd1 
> 
> Diff: https://reviews.apache.org/r/36890/diff/
> 
> 
> Testing
> -------
> 
> 1. Ran "mvn clean test" in ambari-server, all tests passing. 
> 2. Deployed a 3-node HDFS HA cluster with this change applied (using a vagrant cluster).
 Verified that the cluster deployed as expected, and that the new logging messages are showing
up in ambari-server.log.
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message