ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Review Request 36888: Logging of exceptions in python code in Ambari Agent
Date Tue, 28 Jul 2015 12:45:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36888/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-12564
    https://issues.apache.org/jira/browse/AMBARI-12564


Repository: ambari


Description
-------

Today if Ambari Agent python code throws the exception and the stack trace get
rerouted to /var/log/ambari_agent/ambari_agent.out . This is not logged by our
agent and therefore it makes it hard to RCA Ambari Agent failures, let alone
know that Ambari Agent failed.  
I am hoping it is possible to wrap the entry code to Ambari Agent in a
try/catch and log the error message and stack trace to the log appenders and
only then have ambari agent throw.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/main.py 0971cbb 

Diff: https://reviews.apache.org/r/36888/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message