ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vitalyi Brodetskyi" <vbrodets...@hortonworks.com>
Subject Review Request 36843: There's no easy way to start all host components on a host via the API
Date Mon, 27 Jul 2015 07:28:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36843/
-----------------------------------------------------------

Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-12547
    https://issues.apache.org/jira/browse/AMBARI-12547


Repository: ambari


Description
-------

While issuing the API to try to start all host components on c6401:
{code}
curl --user admin:admin  -H  "X-Requested-By: ambari" -i -X PUT -d '{"HostRoles":{"state":"STARTED"}}'
http://`hostname -f`:8080/api/v1/clusters/c1/hosts/c6401.ambari.apache.org/host_components
{code}
*Response*
{code}
{
  "status" : 400,
  "message" : "java.lang.IllegalArgumentException: Invalid desired state for a client component"
}
{code}

*Note:* There was no serviceComponent name specified but the API treats this scenario as start
request has been made on client component

Currently, you have to explicitly specify all the host components that you wish to start.
 This is very cumbersome and not user friendly.
We also cannot do something like /api/v1/clusters/c1/hosts/c6401.ambari.apache.org/host_components?HostRoles/is_client!=true


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
d7fc33b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
46dbb8e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
c38b142 

Diff: https://reviews.apache.org/r/36843/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message