ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vivek Ratnavel Subramanian" <vivekratnave...@gmail.com>
Subject Review Request 36806: Enabling full screen for ambari views iframe
Date Sat, 25 Jul 2015 00:23:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36806/
-----------------------------------------------------------

Review request for Ambari.


Repository: ambari


Description
-------

The "allowfullscreen" attribute of iframe needs to be set to "true" for the components in
the iframe to toggle full screen. The "iframe" tag used in ambari-web to display different
views does not have this attribute enabled. This is required for the visualization component
of hive views to toggle full screen.


Diffs
-----

  ambari-web/app/views/main/views/details.js e90cb20 

Diff: https://reviews.apache.org/r/36806/diff/


Testing
-------


Thanks,

Vivek Ratnavel Subramanian


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message