ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 36739: Kerberos: Allow setting/clearing attributes for MIT KDC identities
Date Fri, 24 Jul 2015 00:16:55 GMT


> On July 23, 2015, 4:07 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java,
lines 195-196
> > <https://reviews.apache.org/r/36739/diff/1/?file=1020079#file1020079line195>
> >
> >     No need for double formatting, logging arguments already via:
> >     LOG.error("Failed to execute foo {} with {}", value1, value2)

Fixed in rev 2.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36739/#review92796
-----------------------------------------------------------


On July 23, 2015, 8:16 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36739/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 8:16 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Nate Cole, Robert Nettleton,
and Tom Beerbower.
> 
> 
> Bugs: AMBARI-12501
>     https://issues.apache.org/jira/browse/AMBARI-12501
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Allow for attributes to be set (or unset) for identities created in an MIT (or similar)
KDC. 
> 
> A user should be able to specify a list of attributes to be set or unset while creating
identities using the MIT kadmin utility. For example:
> ```
> -requires_preauth max_renew_life=7d
> ```
> 
> *Solution*
> Add property `kerberos-env/kdc_create_attributes` to store the user-specified attributes.
> Change `kerberos-env/create_attributes_template` to `kerberos-env/ad_create_attributes_template`
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
33350c0 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
20426f0 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
29fb4b5 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
bc45970 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog211.java
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
e9665f3 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java
d7fffb2 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
9b9a28c 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java
PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json
d56d08e 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 8b10691 
>   ambari-server/src/test/python/stacks/2.2/configs/pig-service-check-secure.json ca7e521

>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 5776a1e

>   ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 633ce75

>   ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 19e68d9 
>   ambari-web/app/assets/data/stacks/HDP-2.2/configurations.json fcaa96d 
>   ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 18b714b 
>   ambari-web/app/data/HDP2/site_properties.js e359a41 
> 
> Diff: https://reviews.apache.org/r/36739/diff/
> 
> 
> Testing
> -------
> 
> Manually tested upgrading from 2.1.0 to 2.1.1 to see relevant property updated
> Manually tested enabling Kerbreros to see _custom_ attributes appled
> 
> #Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message