ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jayush Luniya" <jlun...@hortonworks.com>
Subject Re: Review Request 35844: Update poms to target 1.7 and 1.6 JREs
Date Thu, 23 Jul 2015 23:29:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35844/#review92828
-----------------------------------------------------------



File Attachment: AMBARI-12134-5.patch - AMBARI-12134-5.patch
<https://reviews.apache.org//r/35844/#fcomment72>

    The patch looks incorrect. Why is this section of coding being removed?



File Attachment: AMBARI-12134-5.patch - AMBARI-12134-5.patch
<https://reviews.apache.org//r/35844/#fcomment73>

    The patch looks incorrect. Why is this section of coding being removed?



File Attachment: AMBARI-12134-5.patch - AMBARI-12134-5.patch
<https://reviews.apache.org//r/35844/#fcomment74>

    The patch looks incorrect. Why is this section of coding being removed?



File Attachment: AMBARI-12134-5.patch - AMBARI-12134-5.patch
<https://reviews.apache.org//r/35844/#fcomment75>

    Why do we need to make this class public?



File Attachment: AMBARI-12134-5.patch - AMBARI-12134-5.patch
<https://reviews.apache.org//r/35844/#fcomment76>

    The patch looks incorrect. Why is this line being removed?


- Jayush Luniya


On July 23, 2015, 8:48 p.m., Jonathan Halterman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35844/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 8:48 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12134
>     https://issues.apache.org/jira/browse/AMBARI-12134
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The ambari parent pom is targeted towards Java 1.6 while ambari uses 1.7 APIs. The ambari
metrics pom is targeted at java 1.5 (by default) while ambari-metrics uses 1.6 APIs. This
causes basic compilation failures, depending on how you build the projects and what tools
you use to work on them. AFAIK Ambari 2.1 and beyond are targeted at 1.7, so the Java versions
in the POMs should be updated to reflect this.
> 
> Aside from changing the target version for the compiler plugin, some other dependencies
had to be updated to more recent versions that support 1.7 compilation.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/pom.xml b4f4ed3 
>   pom.xml 47eac31 
> 
> Diff: https://reviews.apache.org/r/35844/diff/
> 
> 
> Testing
> -------
> 
> All tests pass!
> 
> 
> File Attachments
> ----------------
> 
> AMBARI-12134-5.patch
>   https://reviews.apache.org/media/uploaded/files/2015/07/23/64a89068-aa27-4e37-b61d-f37e2aeed706__AMBARI-12134-5.patch
> 
> 
> Thanks,
> 
> Jonathan Halterman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message