ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 36738: [Preview] Don't send install_packages command to hosts without versionable components
Date Thu, 23 Jul 2015 23:00:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36738/#review92827
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
(line 418)
<https://reviews.apache.org/r/36738/#comment147075>

    Technically, this function doesn't transition to INSTALLED, it fills in the data of the
report to emulate a no-op.


- Alejandro Fernandez


On July 23, 2015, 6:15 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36738/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 6:15 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-12517
>     https://issues.apache.org/jira/browse/AMBARI-12517
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We may skip sending install_packages action to hosts without versionable components,
and instantly transition these hosts to INSTALLED state. That should allow to simplify agent-side
logic for working with repo versions.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
f3714b2 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 6f34b62

>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
972226d 
>   ambari-server/src/main/java/org/apache/ambari/server/events/ActionFinalReportReceivedEvent.java
3ff5031 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java
5b7c2d6 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java fe669bd 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 7a53c21 
>   ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java e59f4aa

>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py bfcef1a

>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py d5ae81d 
> 
> Diff: https://reviews.apache.org/r/36738/diff/
> 
> 
> Testing
> -------
> 
> Python tests are fixed. Few java unit tests are failing yet.
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message