ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 36736: Conf-select calls should tolerate failure on existing directory
Date Thu, 23 Jul 2015 19:33:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36736/#review92793
-----------------------------------------------------------

Ship it!



ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
(line 166)
<https://reviews.apache.org/r/36736/#comment147041>

    Maybe a warning? This should only happen in an environment that probably won't work anyway.
The warning might make it more obvious.


- Jonathan Hurley


On July 23, 2015, 2:39 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36736/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 2:39 p.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-12515
>     https://issues.apache.org/jira/browse/AMBARI-12515
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In some cases, clusters are re-installed from "dirty" hosts, such that some conf directories
exist, even though the corresponding package does not install.  conf-select (the binary) correctly
knows this.  Fix is to wrap the call in try/except to prevent halting the whole installation.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
2e3f282 
>   ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py
48c7306 
> 
> Diff: https://reviews.apache.org/r/36736/diff/
> 
> 
> Testing
> -------
> 
> Manual reproduced and fixed on live install.
> 
> Total run:804
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message