ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 36564: Deleting a host using the API causes NPE
Date Fri, 17 Jul 2015 01:16:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36564/#review91999
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java

<https://reviews.apache.org/r/36564/#comment145829>

    Can yo revert this change?



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
(line 762)
<https://reviews.apache.org/r/36564/#comment145833>

    Is it intentional? Do we have similar pattern of creating a different logger elsewhere?
Usually we create one with the class name.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
(line 776)
<https://reviews.apache.org/r/36564/#comment145841>

    Good catch



ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
(line 1162)
<https://reviews.apache.org/r/36564/#comment145835>

    There could be more reasons for NPE. Is it still needed considering we have added logic
to tolerate null in other places?


- Sumit Mohanty


On July 17, 2015, 12:38 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36564/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 12:38 a.m.)
> 
> 
> Review request for Ambari, John Speidel, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-12429
>     https://issues.apache.org/jira/browse/AMBARI-12429
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Created a cluster with multiple hosts, then stopped all of the services on 1 host (preferably
one with only clients so it has nothing to stop). Then deleted the host using the API.
> E.g., curl -u admin:admin -H "X-Requested-By: ambari" -X DELETE http://c6401.ambari.apache.org:8080/api/v1/hosts/c6404.ambari.apache.org
> This led to Null Pointer Exceptions in ambari-server
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java faebb20

>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
de9ae52 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
4c14426 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestOperationLevel.java
c7c0160 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
fa49d7f 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestOperationLevelDAO.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestOperationLevelEntity.java
2c11e55 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
665dd56 
>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
9f25ad7 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestOperationLevelTest.java
bd4ad90 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
ed8336e 
> 
> Diff: https://reviews.apache.org/r/36564/diff/
> 
> 
> Testing
> -------
> 
> Still running system tests, and waiting for unit test results.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message