ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Florian Barca" <fba...@hortonworks.com>
Subject Re: Review Request 35944: Windows unit tests: Metrics unit tests: fix the imports & failing patches
Date Thu, 16 Jul 2015 22:41:16 GMT


> On July 2, 2015, 2:40 p.m., Jayush Luniya wrote:
> > I see this error on Mac
> > 
> > Running tests
> > Traceback (most recent call last):
> >   File "unitTests.py", line 139, in <module>
> >     sys.exit(main())
> >   File "unitTests.py", line 108, in main
> >     modules]
> >   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/loader.py",
line 91, in loadTestsFromName
> >     module = __import__('.'.join(parts_copy))
> >   File "/Users/jluniya/merge2/trunk/ambari/ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py",
line 26, in <module>
> >     from only_for_platform import get_platform, os_distro_value, PLATFORM_WINDOWS
> > ImportError: cannot import name os_distro_value
> > [INFO] ------------------------------------------------------------------------
> > [INFO] Reactor Summary:
> > [INFO]
> > [INFO] ambari-metrics .................................... SUCCESS [10.086s]
> > [INFO] Ambari Metrics Common ............................. SUCCESS [6.113s]
> > [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [2.915s]
> > [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.481s]
> > [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [2.738s]
> > [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.137s]
> > [INFO] Ambari Metrics Collector .......................... SUCCESS [5:35.132s]
> > [INFO] Ambari Metrics Monitor ............................ FAILURE [2.347s]
> > [INFO] Ambari Metrics Assembly ........................... SKIPPED
> > [INFO] ------------------------------------------------------------------------
> > [INFO] BUILD FAILURE
> > [INFO] ------------------------------------------------------------------------
> > [INFO] Total time: 6:02.428s
> > [INFO] Finished at: Thu Jul 02 07:38:14 PDT 2015
> > [INFO] Final Memory: 55M/386M
> > [INFO] ------------------------------------------------------------------------

The patch depends on AMBARI-12036 (the "Depends on" link near the upper right corner is infrequently
used and hence easy to overlook).


- Florian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35944/#review90229
-----------------------------------------------------------


On June 26, 2015, 9:07 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35944/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 9:07 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-12177
>     https://issues.apache.org/jira/browse/AMBARI-12177
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed the imports. Coalesced the OS mock.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py 56e6475df99dd71040f318d28d72ba7c9c36d405

>   ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestMetricCollector.py
30cc023d6089ab02b4e01b05c1efab9e2cc0a6d7 
>   ambari-metrics/ambari-metrics-host-monitoring/src/test/python/unitTests.py 3469de12be3083fefedf204283498c1fb274d52e

> 
> Diff: https://reviews.apache.org/r/35944/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test on Linux and Windows
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message